Skip to content

[BEAM-12564] Implement Series.hasnans #15729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2021
Merged

[BEAM-12564] Implement Series.hasnans #15729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6db194b
[BEAM-12564] Initial implementation hasnans
benEng Oct 13, 2021
db74efa
[BEAM-12564] Add Series.hasnans to DataFrame API
benEng Oct 14, 2021
eb1467c
[BEAM-12564] Fix mypy warnings
benEng Oct 15, 2021
5d7d494
[BEAM-12564] Renaming and fix combine function at Series.hasnas
benEng Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions sdks/python/apache_beam/dataframe/frames.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1098,6 +1098,23 @@ def fn(s):
requires_partition_by=partitionings.Arbitrary(),
preserves_partition_by=partitionings.Arbitrary())

@property # type: ignore
@frame_base.with_docs_from(pd.Series)
def hasnans(self):
has_nans = expressions.ComputedExpression(
'hasnans',
lambda s: pd.Series(s.hasnans), [self._expr],
requires_partition_by=partitionings.Arbitrary(),
preserves_partition_by=partitionings.Singleton())

with expressions.allow_non_parallel_operations():
return frame_base.DeferredFrame.wrap(
expressions.ComputedExpression(
'combine_hasnans',
lambda s: s.any(), [has_nans],
requires_partition_by=partitionings.Singleton(),
preserves_partition_by=partitionings.Singleton()))

@property # type: ignore
@frame_base.with_docs_from(pd.Series)
def dtype(self):
Expand Down
9 changes: 9 additions & 0 deletions sdks/python/apache_beam/dataframe/frames_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,6 +661,15 @@ def test_series_getitem(self):
def test_series_is_unique(self, series):
self._run_test(lambda s: s.is_unique, series)

@parameterized.expand([
(pd.Series(range(10)), ), # False
(pd.Series([1, 2, np.nan, 3, np.nan]), ), # True
(pd.Series(['a', 'b', 'c', 'd', 'e']), ), # False
(pd.Series(['a', 'b', None, 'c', None]), ), # True
])
def test_series_hasnans(self, series):
self._run_test(lambda s: s.hasnans, series)

def test_dataframe_getitem(self):
df = pd.DataFrame({'A': [x**2 for x in range(6)], 'B': list('abcdef')})
self._run_test(lambda df: df['A'], df)
Expand Down