Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1579] Add a Dataflow-specific primitive for creating a view #2387

Closed
wants to merge 2 commits into from

Conversation

tgroh
Copy link
Member

@tgroh tgroh commented Mar 31, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

Allows overrides of CreatePCollectionView to work with the batch
override API.

Allows overrides of CreatePCollectionView to work with the batch
override API.
@tgroh
Copy link
Member Author

tgroh commented Mar 31, 2017

Run Dataflow RunnableOnService

translateTyped(transform, context);
}

private <ElemT, ViewT> void translateTyped(
View.CreatePCollectionView<ElemT, ViewT> transform, TranslationContext context) {
CreateDataflowView<ElemT, ViewT> transform, TranslationContext context) {
LOG.info("Translating transform {} for view {}", transform, transform.getView());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.

@dhalperi
Copy link
Contributor

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 70.341% when pulling 1fc6db1 on tgroh:create_dataflow_view into 7057d1e on apache:master.

@asfbot
Copy link

asfbot commented Mar 31, 2017

@tgroh
Copy link
Member Author

tgroh commented Mar 31, 2017

Run Dataflow ValidatesRunner

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 70.334% when pulling 1fa1379 on tgroh:create_dataflow_view into 62473ae on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 70.331% when pulling 1fa1379 on tgroh:create_dataflow_view into 62473ae on apache:master.

@asfbot
Copy link

asfbot commented Mar 31, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9005/
--none--

@asfbot
Copy link

asfbot commented Mar 31, 2017

@tgroh
Copy link
Member Author

tgroh commented Mar 31, 2017

retest this please

@coveralls
Copy link

coveralls commented Mar 31, 2017

Coverage Status

Coverage increased (+25.3%) to 95.596% when pulling 1fa1379 on tgroh:create_dataflow_view into 62473ae on apache:master.

@asfbot
Copy link

asfbot commented Mar 31, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9012/
--none--

@asfbot
Copy link

asfbot commented Mar 31, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/2704/
--none--

@dhalperi
Copy link
Contributor

dhalperi commented Apr 3, 2017

R: @dhalperi

Still LGTM, please self-merge when ready.

@asfgit asfgit closed this in 9beb04e Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants