-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-1579] Add a Dataflow-specific primitive for creating a view #2387
Conversation
Allows overrides of CreatePCollectionView to work with the batch override API.
Run Dataflow RunnableOnService |
translateTyped(transform, context); | ||
} | ||
|
||
private <ElemT, ViewT> void translateTyped( | ||
View.CreatePCollectionView<ElemT, ViewT> transform, TranslationContext context) { | ||
CreateDataflowView<ElemT, ViewT> transform, TranslationContext context) { | ||
LOG.info("Translating transform {} for view {}", transform, transform.getView()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No.
LGTM |
8e158b9
to
1fa1379
Compare
Run Dataflow ValidatesRunner |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-runners-spark: 1--none-- |
retest this please |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
R: @dhalperi Still LGTM, please self-merge when ready. |
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull request
mvn clean verify
. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>
in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
Allows overrides of CreatePCollectionView to work with the batch
override API.