Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kamel cli installable via Homebrew #1369

Closed
edeandrea opened this issue Mar 23, 2020 · 13 comments
Closed

Make kamel cli installable via Homebrew #1369

edeandrea opened this issue Mar 23, 2020 · 13 comments

Comments

@edeandrea
Copy link

It would be a really nice addition to be able to install the kamel cli via Homebrew for Macos users.

@ipolyzos
Copy link
Contributor

I would be happy to take over this task.

I have created an initial tap for your feedback at kamel-homebrew-tap.

@ipolyzos
Copy link
Contributor

ipolyzos commented Apr 15, 2020

Could you please advise on how a PR should be structured? (path etc)

@edeandrea
Copy link
Author

I can't seem to tap it

$ brew tap ipolyzos/kamel-homebrew-tap
==> Tapping ipolyzos/kamel-homebrew-tap
Cloning into '/usr/local/Homebrew/Library/Taps/ipolyzos/homebrew-kamel-homebrew-tap'...
remote: Repository not found.
fatal: repository 'https://github.com/ipolyzos/homebrew-kamel-homebrew-tap/' not found
Error: Failure while executing; `git clone https://github.com/ipolyzos/homebrew-kamel-homebrew-tap /usr/local/Homebrew/Library/Taps/ipolyzos/homebrew-kamel-homebrew-tap` exited with 128.

According to the taps guide for repository naming conventions the repository name should start with homebrew.

@ipolyzos
Copy link
Contributor

ipolyzos commented Apr 15, 2020

The repo does not comply the default naming (user/homebrew-tap) thus why it fails [1] indeed. If you please try the format :

brew tap <user/repo> <URL>

e.g

brew tap ipolyzos/tap https://github.com/ipolyzos/kamel-homebrew-tap

Please see below my log:

$ brew tap ipolyzos/tap https://github.com/ipolyzos/kamel-homebrew-tap                                                                             git:(master|) 
==> Tapping ipolyzos/tap
Cloning into '/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/ipolyzos/homebrew-tap'...
^[[Aremote: Enumerating objects: 6, done.
remote: Counting objects: 100% (6/6), done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 6 (delta 1), reused 6 (delta 1), pack-reused 0
Unpacking objects: 100% (6/6), 4.67 KiB | 2.33 MiB/s, done.
Tapped 1 formula (33 files, 133.9KB).
$ brew install kamel                                                                                                                               git:(master|) 
==> Installing kamel from ipolyzos/tap
==> Cloning https://github.com/apache/camel-k.git
Updating /home/ipolyzos/.cache/Homebrew/kamel--git
==> Checking out tag 1.0.0-RC2
HEAD is now at 24ddce5 Release 1.0.0-RC2
HEAD is now at 24ddce5 Release 1.0.0-RC2
==> make
==> Caveats
Bash completion has been installed to:
  /home/linuxbrew/.linuxbrew/etc/bash_completion.d

zsh completions have been installed to:
  /home/linuxbrew/.linuxbrew/share/zsh/site-functions
==> Summary
🍺  /home/linuxbrew/.linuxbrew/Cellar/kamel/1.0.0-RC2: 8 files, 59.7MB, built in 1 minute 4 seconds

@nicolaferraro
Copy link
Member

@ipolyzos would it work if you contribute that rb file to: https://github.com/Homebrew/homebrew-core/tree/master/Formula ?

I think that's the main repo for brew.

After that is merged we can update our release process to update its version once a new one is released. That's the same thing we do for operator hub.

Can it work?

@ipolyzos
Copy link
Contributor

Absolutely, I will contribute to the suggested repo.

@ipolyzos
Copy link
Contributor

ipolyzos commented Apr 21, 2020

Please see below for the relevant PRs in the HomeBrew and LinuxBrew core projects:

@ipolyzos
Copy link
Contributor

ipolyzos commented May 5, 2020

The HomeBrew PR got accepted and is in a ready-to-merge state.

It is expected soon to be available.

@ipolyzos
Copy link
Contributor

ipolyzos commented May 5, 2020

The formula is live.

Now users can install kamel using Homebrew or Linuxbrew respectively.

e.g
$ brew install kamel

@nicolaferraro
Copy link
Member

Thanks @ipolyzos!
Can you update the https://github.com/apache/camel-k/blob/master/release.adoc last section (Post Release) with information on what to update when we release a new version of Camel K?

@ipolyzos
Copy link
Contributor

ipolyzos commented May 7, 2020

Done, for the update please refer to the PR 1454.

If you could please review, it would be great.

@nicolaferraro
Copy link
Member

Thanks!

@ipolyzos
Copy link
Contributor

ipolyzos commented May 7, 2020

Thanks!

Glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants