Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging configuration does not affect integrations #2000

Closed
nicolaferraro opened this issue Feb 4, 2021 · 7 comments
Closed

Logging configuration does not affect integrations #2000

nicolaferraro opened this issue Feb 4, 2021 · 7 comments
Assignees
Labels
good first issue Does not require full understanding of the codebase kind/bug Something isn't working
Milestone

Comments

@nicolaferraro
Copy link
Member

Setting logging.level.org.apache.camel=DEBUG does not affect integration logs.

So if users set flag --logging-level org.apache.camel=DEBUG, that is currently translated into the property above and does not work.

The correct mapping should be something like: quarkus.log.category."org.apache.camel".level=DEBUG

We should also change the doc to point to the Quarkus documentation for configuring the log via properties.

@nicolaferraro nicolaferraro added kind/bug Something isn't working good first issue Does not require full understanding of the codebase labels Feb 4, 2021
@nicolaferraro nicolaferraro added this to the 1.3.2 milestone Feb 4, 2021
@lburgazzoli
Copy link
Contributor

with the main runtime there were some code to translate the property to the log4j2 format, maybe we should do the same here ? or map directly to the quarkus ones ?

@nicolaferraro
Copy link
Member Author

with the main runtime there were some code to translate the property to the log4j2 format, maybe we should do the same here ? or map directly to the quarkus ones ?

Allowing the logging.level. syntax and map them to quarkus would be better I think

@nicolaferraro nicolaferraro modified the milestones: 1.3.2, 1.4.0 Mar 19, 2021
@nicolaferraro nicolaferraro modified the milestones: 1.4.0, 1.5.0 Apr 13, 2021
@orpiske
Copy link
Contributor

orpiske commented May 3, 2021

I am going to take care of this issue as part of the logging trait changes.

@orpiske orpiske self-assigned this May 3, 2021
orpiske added a commit to orpiske/camel-k that referenced this issue May 3, 2021
orpiske added a commit that referenced this issue May 3, 2021
orpiske added a commit to orpiske/camel-k that referenced this issue May 3, 2021
orpiske added a commit that referenced this issue May 4, 2021
@astefanutti
Copy link
Member

@orpiske with your work on the logging trait, I think we could "simply" remove the --logging-level option from the run command, and have it replaced with -t logging.level. WDYT?

@orpiske
Copy link
Contributor

orpiske commented Jun 7, 2021

@orpiske with your work on the logging trait, I think we could "simply" remove the --logging-level option from the run command, and have it replaced with -t logging.level. WDYT?

+1 for that. I can send a PR this week with the proposed code to remove it.

@astefanutti
Copy link
Member

+1 for that. I can send a PR this week with the proposed code to remove it.

Great, thanks!

@astefanutti
Copy link
Member

Fixed with #2377.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Does not require full understanding of the codebase kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants