Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the deprecated --logging-level option (issue #2000) #2377

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

orpiske
Copy link
Contributor

@orpiske orpiske commented Jun 8, 2021

Release Note

NONE

@orpiske orpiske requested a review from astefanutti June 8, 2021 13:10
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to rebase camel-main on main at some point.

Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love reviewing "delete only" PR 😉!

@orpiske
Copy link
Contributor Author

orpiske commented Jun 8, 2021

We'll need to rebase camel-main on main at some point.

+1. I think we need to do it this week to not get too far behind on camel-main

@oscerd
Copy link
Contributor

oscerd commented Jun 8, 2021

We'll need to rebase camel-main on main at some point.

+1. I think we need to do it this week to not get too far behind on camel-main

Yeah, here and on camel-k-runtime

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleaning work. I think we should include some documentation though in order to let the people know how to use/edit the logging trait. If we have it missing at all, we should take the opportunity and add a little entry (maybe under running/log menu section) explaining how to do that.

@orpiske
Copy link
Contributor Author

orpiske commented Jun 8, 2021

Nice cleaning work. I think we should include some documentation though in order to let the people know how to use/edit the logging trait. If we have it missing at all, we should take the opportunity and add a little entry (maybe under running/log menu section) explaining how to do that.

Thanks. We actually have the logging.trait documented within the traits: https://camel.apache.org/camel-k/latest/traits/logging.html.

Maybe we should make it more easily accessible in the home page?

@astefanutti
Copy link
Member

Nice cleaning work. I think we should include some documentation though in order to let the people know how to use/edit the logging trait. If we have it missing at all, we should take the opportunity and add a little entry (maybe under running/log menu section) explaining how to do that.

Thanks. We actually have the logging.trait documented within the traits: https://camel.apache.org/camel-k/latest/traits/logging.html.

Maybe we should make it more easily accessible in the home page?

I'd suggest to create a "Logging" page, under the "Observability" one, along with the existing monitoring documentation: https://camel.apache.org/camel-k/latest/observability/monitoring.html. At least that was the original intent of the "Observability" section, grouping Logging, Monitoring, and Tracing.

@squakez
Copy link
Contributor

squakez commented Jun 8, 2021

Yeah, I think we should have a dedicated section that will link to the log trait page as well. I'd say a short entry under /running/log would be enough for now.

EDIT: as suggested by @astefanutti also an entry in the Observability could be good.

@orpiske
Copy link
Contributor Author

orpiske commented Jun 8, 2021

@astefanutti @squakez Thanks. Let me add the documentation as part of this PR before we merge this.

I'm also wondering if we should include some simpler/smaller version of this as well: https://camel.apache.org/blog/2021/05/new-camel-k-logging-features/.

If you have any suggestions, please let me know :)

@squakez
Copy link
Contributor

squakez commented Jun 8, 2021

@astefanutti @squakez Thanks. Let me add the documentation as part of this PR before we merge this.

I'm also wondering if we should include some simpler/smaller version of this as well: https://camel.apache.org/blog/2021/05/new-camel-k-logging-features/.

If you have any suggestions, please let me know :)

Thanks @orpiske, I think a short version with basic info should be okey. From there you can add a link to the trait page where we explain more in details all those aspects.

@astefanutti
Copy link
Member

astefanutti commented Jun 8, 2021

@orpiske the content from https://camel.apache.org/blog/2021/05/new-camel-k-logging-features would be exactly what's needed. I'd suggest to mimic the existing organisation from the monitoring documentation, that is two pages, Operator and Integration, within Observability > Logging. Also a link from the Running page to the Integration logging one could be good as suggested by @squakez.

@orpiske
Copy link
Contributor Author

orpiske commented Jun 9, 2021

Added a bit of documentation.

@astefanutti
Copy link
Member

Awesome, thanks @orpiske!

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@orpiske orpiske merged commit b246a27 into apache:main Jun 9, 2021
@nicolaferraro nicolaferraro mentioned this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants