Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a KameletBinding is invalid, the related status is not updated to report an error #3010

Closed
lburgazzoli opened this issue Feb 14, 2022 · 2 comments · Fixed by #3897
Closed
Labels
area/kamelets kind/bug Something isn't working

Comments

@lburgazzoli
Copy link
Contributor

Assuming a KameletBinding lacks sourece/sink, as example:

piVersion: camel.apache.org/v1alpha1
kind: KameletBinding
metadata:
  name: c82iernvdc4irh6evn20
  namespace: default
spec:
  integration:
    configuration:
    - type: secret
      value: c82iernvdc4irh6evn20
    profile: OpenShift
  steps: []

The operator will fail with something like:

{
  "level":"error",
  "ts":1644832192.1764352,
  "logger":"controller.kamelet-binding-controller",
  "msg":"Reconciler error",
  "name":"c82iernvdc4irh6evn20",
  "namespace":"cos",
  "error":"could not determine source URI: no ref or URI specified in endpoint",
  "errorVerbose":"no ref or URI specified in endpoint"
}

But the error is not reported in the KameletBinding's status

@lburgazzoli lburgazzoli added kind/bug Something isn't working area/kamelets labels Feb 14, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@squakez
Copy link
Contributor

squakez commented Aug 9, 2022

This is similar to #3389 . The problem is that we don't set an upper limit for retries in the reconciliation loop (we probably do it only for the Build CR), so, this is left pending until the fix is applied. I wonder if we should immediately at least report the error condition or stop reconciliation when these kind of situations happen.

squakez added a commit to squakez/camel-k that referenced this issue Dec 13, 2022
* Expose trait failures into Integration status
* KameletBinding will report an Error when it cannot create an Integration for any reason

Closes apache#3389
Closes apache#3010
squakez added a commit that referenced this issue Dec 15, 2022
* Expose trait failures into Integration status
* KameletBinding will report an Error when it cannot create an Integration for any reason

Closes #3389
Closes #3010
squakez added a commit to squakez/camel-k that referenced this issue Jan 17, 2023
* Expose trait failures into Integration status
* KameletBinding will report an Error when it cannot create an Integration for any reason

Closes apache#3389
Closes apache#3010
squakez added a commit to squakez/camel-k that referenced this issue Jan 19, 2023
* Expose trait failures into Integration status
* KameletBinding will report an Error when it cannot create an Integration for any reason

Closes apache#3389
Closes apache#3010
squakez added a commit to squakez/camel-k that referenced this issue Jan 19, 2023
* Expose trait failures into Integration status
* KameletBinding will report an Error when it cannot create an Integration for any reason

Closes apache#3389
Closes apache#3010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kamelets kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants