-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate errors to KameletBinding status #3389
Comments
I had a look at this and I don't think it's a bug but the way it is designed the system so far (we may understand if it makes sense to change it though). Right now, if an The scenario illustrated in the description is more generic because we never set an We may reason if it makes sense to apply some retry logic (as we do for the Adding @astefanutti @lburgazzoli @oscerd to the thread for more opinions. |
We should review how the re-queue of reconciliation events is handled by controller-runtime. For errors, in general, we should configure the work-queue to use a rate-limited queue with an exponential failure rate limiter, cap the maximum number of retries, and eventually report the error in the custom resource status and forget the element from the queue. For functional errors, that we know won't be resolved by retrying, we may want to shortcut that mechanism and directly report the error in the custom resource status. |
This issue has been automatically marked as stale due to 90 days of inactivity. |
* Expose trait failures into Integration status * KameletBinding will report an Error when it cannot create an Integration for any reason Closes apache#3389 Closes apache#3010
* Expose trait failures into Integration status * KameletBinding will report an Error when it cannot create an Integration for any reason Closes apache#3389 Closes apache#3010
* Expose trait failures into Integration status * KameletBinding will report an Error when it cannot create an Integration for any reason Closes apache#3389 Closes apache#3010
* Expose trait failures into Integration status * KameletBinding will report an Error when it cannot create an Integration for any reason Closes apache#3389 Closes apache#3010
When there is an error in the operator during the reconciliation of a KameletBinding (e.g. a trait raises some error) the KameletBinding should reflect this error state in its status.
The actual behavior is that the KameletBinding is stuck in "Creating" phase and never recovers from that state.
To reproduce this behavior add a KameletBinding with an unknown Kamelet as a source or sink. The KameletBinding status should reflect the error state and provide some proper reason indicator in its condition status.
The text was updated successfully, but these errors were encountered: