Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reconciliation loops behaviors #3897

Merged
merged 3 commits into from
Dec 15, 2022

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Dec 13, 2022

With this PR we aim to improve the reconciliation loop of Integrations and KameletBindings. The Integration now fails and report the error that may happen during the execution of traits. We also change the reconciliation loop for KameletBindings in order to detect any failure (failing traits, or wrong spec), report an error and stop the reconciliation loop.

Closes #3389
Closes #3010

Release Note

fix: reconciliation loops behaviors

* Expose trait failures into Integration status
* KameletBinding will report an Error when it cannot create an Integration for any reason

Closes apache#3389
Closes apache#3010
@squakez
Copy link
Contributor Author

squakez commented Dec 13, 2022

Still working on more E2E test to have a proper coverage. But I'd like to collect early feedback in the while.

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@squakez squakez merged commit 4189b8d into apache:main Dec 15, 2022
@squakez squakez deleted the fix/reconciliation_loops branch December 15, 2022 08:17
@oscerd oscerd mentioned this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants