Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade can result in integration being rebuilt using the old integrationkit #3359

Closed
phantomjinx opened this issue Jun 15, 2022 · 5 comments
Labels
area/build-operator Related to the internal image build operator kind/bug Something isn't working status/waiting-for-feedback Needs some feedback

Comments

@phantomjinx
Copy link
Contributor

phantomjinx commented Jun 15, 2022

The e2e tests reveal that on occasion, eg. here, an upgade of camel-k can result in an existing integration being rebuilt with the existing (not-upgraded) integrationkit.

1 integrations have been rebuilt
    cli_upgrade_test.go:107: 
        Timed out after 300.020s.
        Expected
            <string>: kit-cakddkimeh84ri4ora90
        to equal
            <string>: kit-cakddkimeh84ri4ora8g

The problem, of course, is this only happens in the test suite occasionally, so it is difficult to pin-down due to not being a consistent error. Therefore, is this something to warrant enough concern to be investigated?

@squakez
Copy link
Contributor

squakez commented Jun 15, 2022

Interesting... we're talking about same stuff in #3341 I start thinking that the rebuild should build from scratch then...

@squakez squakez added kind/bug Something isn't working area/build-operator Related to the internal image build operator labels Jun 15, 2022
@squakez
Copy link
Contributor

squakez commented Jul 13, 2022

I had a look at this. I did not manage to replicate the issue. Actually it happens that when we do a kamel rebuild after a Camel K operator upgrade, the Integration.Status is wiped and a new IntegrationKit build is triggered as well (as the new operator version dependencies are different from the old ones). Which is the method we're using in the E2E tests to ask for a rebuild after an upgrade is performed?

@phantomjinx
Copy link
Contributor Author

This is where the olm upgrade tests starts the upgrade -> https://github.com/apache/camel-k/blob/main/e2e/namespace/upgrade/olm_upgrade_test.go#L120

@squakez
Copy link
Contributor

squakez commented Jul 13, 2022

Looks good then. FYI, I've noticed that from 1.8 to 1.9 we were suffering rebuilds issues, but the seems to be gone from 1.9 to 1.10(nightly). Was the original reported issue test upgrading from 1.8 to 1.9?

@squakez squakez added the status/waiting-for-feedback Needs some feedback label Jul 21, 2022
@phantomjinx
Copy link
Contributor Author

I think this has now been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-operator Related to the internal image build operator kind/bug Something isn't working status/waiting-for-feedback Needs some feedback
Projects
None yet
Development

No branches or pull requests

2 participants