Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically make generate every night #3868

Closed
squakez opened this issue Dec 1, 2022 · 3 comments · Fixed by #3911
Closed

Automatically make generate every night #3868

squakez opened this issue Dec 1, 2022 · 3 comments · Fixed by #3911
Assignees
@squakez
Labels
area/continuous integration Related to CI and automated testing

Comments

@squakez
Copy link
Contributor

squakez commented Dec 1, 2022 •
edited
Loading

We can run a new task into the changelog workflow (and name it differently) to run a make generate every night and include any change in API, doc, whatever is regenerated automatically to avoid forgetting stuff or writing code that will be cleaned eventually.

Ref #3818 #3867
@squakez squakez added the area/continuous integration Related to CI and automated testing label Dec 1, 2022
@tadayosi
Copy link
Member

tadayosi commented Dec 2, 2022

Also let's not forget to run make build in the same workflow and update pkg/resources/resources.go nightly.

@squakez
Copy link
Contributor Author

squakez commented Dec 2, 2022

Also let's not forget to run make build in the same workflow and update pkg/resources/resources.go nightly.

Thinking more carefully, do you think the resources.go should be at all something to refresh in the repo? after all, this is always regenerated, I'd be even inclined to git ignore it in order to reduce any possibility of conflict. However, I am not 100% sure of what could be a best practice with this kind of golang resource.

@tadayosi
Copy link
Member

tadayosi commented Dec 8, 2022

@squakez Good point. resources.go is generated every time we build so it seems to be possible to ignore it from git. I'm not sure if it's 100% ok to remove it from the repo, either, though.

A while ago I filed another idea to remove resources.go from the repo. go:embed is another way to embed resources in the code without need for regeneration each time.

@squakez squakez self-assigned this Dec 15, 2022
squakez added a commit to squakez/camel-k that referenced this issue Dec 15, 2022
@squakez
feat(ci): automatic make generate
71f9565 
* run `make generate` every night to refresh automatically the autogenerated resources
* ignore resource.go

Closes apache#3868
@squakez squakez mentioned this issue Dec 15, 2022
Merged
squakez added a commit that referenced this issue Dec 15, 2022
@squakez
feat(ci): automatic make generate
d6d593f 
* run `make generate` every night to refresh automatically the autogenerated resources
* ignore resource.go

Closes #3868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squakez squakez

Labels
area/continuous integration Related to CI and automated testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ci): automatic make generate squakez/camel-k
2 participants
@tadayosi @squakez