Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make generate removes PatchScale func #3818

Closed
squakez opened this issue Nov 16, 2022 · 2 comments · Fixed by #3874
Closed

make generate removes PatchScale func #3818

squakez opened this issue Nov 16, 2022 · 2 comments · Fixed by #3874
Labels
kind/bug Something isn't working

Comments

@squakez
Copy link
Contributor

squakez commented Nov 16, 2022 •
edited
Loading

For some reason the generation is removing such func from client/camel/clientset/versioned/typed/camel/v1/integration.go. Also from related fake_integration.go
@squakez squakez added the kind/bug Something isn't working label Nov 16, 2022
@squakez
Copy link
Contributor Author

squakez commented Dec 1, 2022 •
edited
Loading

This one is a regression introduced by: 69ded07 The change is good, but we need this to be autogenerated as those resources are regenerated (therefore those changes removed) via make generate every time we run it.

@squakez
Copy link
Contributor Author

squakez commented Dec 1, 2022

fyi @phantomjinx @tadayosi

@squakez squakez mentioned this issue Dec 1, 2022
Closed
squakez added a commit to squakez/camel-k that referenced this issue Dec 2, 2022
@squakez
fix(e2e): use generated API methods
0de8d25 
Closes apache#3818
@squakez squakez mentioned this issue Dec 2, 2022
Merged
@squakez squakez closed this as completed in b162222 Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(e2e): use generated API methods squakez/camel-k
1 participant
@squakez