feat(ci): automatic make generate #3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* run `make generate` every night to refresh automatically the autogenerated resources * ignore resource.go Closes apache#3868
oscerd
approved these changes
Dec 15, 2022
|
🤞 for tonight... |
tadayosi
reviewed
Dec 16, 2022
| @@ -168,3 +168,4 @@ config/**/*.gen.yaml | |||
| config/**/*.gen.json | |||
|
|
|||
| *-installer* | |||
| pkg/resources/resources.go | |||
There was a problem hiding this comment.
@squakez
Btw, simply adding this to .gitignore doesn't ignore future changes to this file. To completely eliminate it from repo, we need to git rm pkg/resources/resources.go as well.
There was a problem hiding this comment.
True. I will fix it, thanks!
There was a problem hiding this comment.
I've made the change in ae815dd, however, since then, the validate is failing. Maybe it required the presence of such a resource to be executed correctly. I'll revert the change to see what happens.
There was a problem hiding this comment.
I confirm, the commit in #3920 will fix that. It seems it is required, so, I will work to regenerate that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we let the github actions to run every night a
make generateand have it therefore a fresh version of the autogenerated resources. Additionally we have now the Changelog updated in all release branches as well. The newautomatic-updatestask can be appendend with any further task if required eventually.Closes #3868
Release Note