Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether it is possible to reduce the amount of RAM spent by the AS2 itest #1672 #1686

Closed

Conversation

JiriOndrusek
Copy link
Contributor

@JiriOndrusek JiriOndrusek commented Sep 3, 2020

Fixes #1672

Adds configuration for bouncycastle extension. It now requires user to define all ciphers and digest at build time, which has impact on memory requirements.

This change can be merged. It is an isolated fix.
I'll continue with the investigation in case that there is another way of reducing requirements of as2 integration test module.

[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix # or Fixes # will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html

@JiriOndrusek JiriOndrusek force-pushed the 1672_as2-too-much-time branch 2 times, most recently from f289035 to f7a799e Compare September 4, 2020 07:19
@JiriOndrusek JiriOndrusek changed the title do not merge! CI testing purposes Check whether it is possible to reduce the amount of RAM spent by the AS2 itest #1672 Sep 4, 2020
@JiriOndrusek JiriOndrusek marked this pull request as ready for review September 4, 2020 12:02
@JiriOndrusek
Copy link
Contributor Author

@ppalaga The current build time is 7 mins faster then before

[INFO] Camel Quarkus :: Integration Tests :: AS2 .......... SUCCESS [18:39 min]

(unfortunately I've missed one System.ot.println in my code, so now it is building again wit the updated code)

I'll try to find another optimization, but IMHO result form the current build is much better then I hoped for.
(I'm attaching log from the previous execution)
9_Native Tests - misc.txt
.

@ppalaga
Copy link
Contributor

ppalaga commented Sep 4, 2020

The current build time is 7 mins faster then before

That's great!

I'd like to clear some questions on Monday, switching to draft till then.

@JiriOndrusek
Copy link
Contributor Author

Replaced by #1723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants