CAMEL-14732: Position footer to be at the bottom of the page #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zregvart
reviewed
Mar 23, 2020
|
Preview is here |
Co-Authored-By: Zoran Regvart <zoran@regvart.com>
Yes, we could use rem instead of em. I saw the preview, it works and I committed those changes. |
|
I don't think this solves the issue, here's an example: This is at 1920x1080 on https://builds.apache.org/job/Camel.website/job/PR-231/Preview/categories/Tooling/ |
zregvart
requested changes
Mar 24, 2020
|
I will try resolving it permanently irrespective of the browser size then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been observed that for certain pages where the content is minimal, the footer is not fixed to the bottom of the page in the desktop version.
Thus, I changed the code such that the footer will remain on the bottom of the page regardless of the minimal text on each webpage.
Issue Observed
Solution Provided