-
Notifications
You must be signed in to change notification settings - Fork 5k
CAMEL-20113 camel/tests consolidating #12594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
/component-test camel-jetty Result ✅ The tests passed successfully |
/component-test camel-jaxb Result ✅ The tests passed successfully |
🤖 The Apache Camel test robot will run the tests for you 👍 |
1 similar comment
🤖 The Apache Camel test robot will run the tests for you 👍 |
components/camel-jaxb/src/test/java/org/apache/camel/jaxb/FallbackTypeConverterTest.java
Show resolved
Hide resolved
components/camel-jaxb/src/test/java/org/apache/camel/jaxb/FallbackTypeConverterTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, thanks for your contribution @kulagaIA!
As you are contributing more often, I took the time to point a few additional things we look for in contributions, so future contributions are easier to merge and adjust to our code base.
In addition to the items I pointed above, one more request: please, can you rebase the commits and rewrite the commit message in the format `CAMEL-20113: camel/tests consolidating" (note the 2 dots separating the ticket from the message - this ensures the commit is automatically associated with the Jira ticket).
Marking as request changes as I am sharing some additional tips to improve future contributions.
06464fc
to
364dbe7
Compare
org.apache.camel.itest.jaxb: -SpringLoadRouteFromXmlTest - moved to the camel-jaxb component; -JaxbFallbackTypeConverterTest - moved to the camel-jaxb component; org.apache.camel.itest.jetty: -JettyBridgeHostHeaderIssueTest - moved to camel-jetty; -JettyConstantSetHeaderTest - setting headers is checked in other camel-jetty tests, so it is deleted; -JettyFailoverRoundRobinTest - moved to camel-jetty; -JettyJmsShutdownInProgressTest - jetty graceful shutdown is checked in org.apache.camel.component.jetty.JettySuspendWhileInProgressTest, so it is deleted; -JettyJmsTest - test was made just to show example route, so it is deleted; -JettyJmsTwowayTest - test was made just to show example route, so it is deleted; -JettyRestRedirectTest - moved to camel-jetty; -JettySimpleSetHeaderTest - setting headers is checked in other camel-jetty tests, so it is deleted; -JettyValidatorStreamTest - moved to camel-jetty; -JettyValidatorTest - moved to camel-jetty; -JettyXsltHttpTemplateTest - moved to camel-jetty; -JettyXsltTest - moved to camel-jetty;
364dbe7
to
c44b0d0
Compare
/component-test camel-jaxb camel-jetty Result ✅ The tests passed successfully |
🤖 The Apache Camel test robot will run the tests for you 👍 |
@orpiske thanks for taking time to guide me! Looks like everything is in order now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying the changes!
Description
org.apache.camel.itest.jaxb:
-SpringLoadRouteFromXmlTest - moved to the camel-jaxb component;
-JaxbFallbackTypeConverterTest - moved to the camel-jaxb component;
org.apache.camel.itest.jetty:
-JettyBridgeHostHeaderIssueTest - moved to camel-jetty;
-JettyConstantSetHeaderTest - setting headers is checked in other camel-jetty tests, so it is deleted;
-JettyFailoverRoundRobinTest - moved to camel-jetty;
-JettyJmsShutdownInProgressTest - jetty graceful shutdown is checked in org.apache.camel.component.jetty.JettySuspendWhileInProgressTest, so it is deleted;
-JettyJmsTest - test was made just to show example route, so it is deleted;
-JettyJmsTwowayTest - test was made just to show example route, so it is deleted;
-JettyRestRedirectTest - moved to camel-jetty;
-JettySimpleSetHeaderTest - setting headers is checked in other camel-jetty tests, so it is deleted;
-JettyValidatorStreamTest - moved to camel-jetty;
-JettyValidatorTest - moved to camel-jetty;
-JettyXsltHttpTemplateTest - moved to camel-jetty;
-JettyXsltTest - moved to camel-jetty;
Tracking
https://issues.apache.org/jira/browse/CAMEL-20113