Skip to content

CAMEL-20113 camel/tests consolidating #12594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

kulagaIA
Copy link
Member

@kulagaIA kulagaIA commented Dec 24, 2023

Description

org.apache.camel.itest.jaxb:
-SpringLoadRouteFromXmlTest - moved to the camel-jaxb component;
-JaxbFallbackTypeConverterTest - moved to the camel-jaxb component;

org.apache.camel.itest.jetty:
-JettyBridgeHostHeaderIssueTest - moved to camel-jetty;
-JettyConstantSetHeaderTest - setting headers is checked in other camel-jetty tests, so it is deleted;
-JettyFailoverRoundRobinTest - moved to camel-jetty;
-JettyJmsShutdownInProgressTest - jetty graceful shutdown is checked in org.apache.camel.component.jetty.JettySuspendWhileInProgressTest, so it is deleted;
-JettyJmsTest - test was made just to show example route, so it is deleted;
-JettyJmsTwowayTest - test was made just to show example route, so it is deleted;
-JettyRestRedirectTest - moved to camel-jetty;
-JettySimpleSetHeaderTest - setting headers is checked in other camel-jetty tests, so it is deleted;
-JettyValidatorStreamTest - moved to camel-jetty;
-JettyValidatorTest - moved to camel-jetty;
-JettyXsltHttpTemplateTest - moved to camel-jetty;
-JettyXsltTest - moved to camel-jetty;

Tracking

https://issues.apache.org/jira/browse/CAMEL-20113

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@kulagaIA
Copy link
Member Author

kulagaIA commented Dec 24, 2023

/component-test camel-jetty

Result ✅ The tests passed successfully

@kulagaIA
Copy link
Member Author

kulagaIA commented Dec 24, 2023

/component-test camel-jaxb

Result ✅ The tests passed successfully

Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

1 similar comment
Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

@kulagaIA kulagaIA marked this pull request as ready for review December 24, 2023 16:19
Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, thanks for your contribution @kulagaIA!

As you are contributing more often, I took the time to point a few additional things we look for in contributions, so future contributions are easier to merge and adjust to our code base.

In addition to the items I pointed above, one more request: please, can you rebase the commits and rewrite the commit message in the format `CAMEL-20113: camel/tests consolidating" (note the 2 dots separating the ticket from the message - this ensures the commit is automatically associated with the Jira ticket).

Marking as request changes as I am sharing some additional tips to improve future contributions.

@kulagaIA kulagaIA force-pushed the camel-test-consolidating branch from 06464fc to 364dbe7 Compare December 25, 2023 15:17
org.apache.camel.itest.jaxb:
-SpringLoadRouteFromXmlTest - moved to the camel-jaxb component;
-JaxbFallbackTypeConverterTest - moved to the camel-jaxb component;

org.apache.camel.itest.jetty:
-JettyBridgeHostHeaderIssueTest - moved to camel-jetty;
-JettyConstantSetHeaderTest - setting headers is checked in other camel-jetty tests, so it is deleted;
-JettyFailoverRoundRobinTest - moved to camel-jetty;
-JettyJmsShutdownInProgressTest - jetty graceful shutdown is checked in org.apache.camel.component.jetty.JettySuspendWhileInProgressTest, so it is deleted;
-JettyJmsTest - test was made just to show example route, so it is deleted;
-JettyJmsTwowayTest - test was made just to show example route, so it is deleted;
-JettyRestRedirectTest - moved to camel-jetty;
-JettySimpleSetHeaderTest - setting headers is checked in other camel-jetty tests, so it is deleted;
-JettyValidatorStreamTest - moved to camel-jetty;
-JettyValidatorTest - moved to camel-jetty;
-JettyXsltHttpTemplateTest - moved to camel-jetty;
-JettyXsltTest - moved to camel-jetty;
@kulagaIA kulagaIA force-pushed the camel-test-consolidating branch from 364dbe7 to c44b0d0 Compare December 25, 2023 15:38
@kulagaIA
Copy link
Member Author

kulagaIA commented Dec 25, 2023

/component-test camel-jaxb camel-jetty

Result ✅ The tests passed successfully

Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

@kulagaIA
Copy link
Member Author

@orpiske thanks for taking time to guide me! Looks like everything is in order now.

@kulagaIA kulagaIA requested a review from orpiske December 25, 2023 15:46
Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the changes!

@orpiske orpiske merged commit a83eaaa into apache:main Dec 26, 2023
@kulagaIA kulagaIA deleted the camel-test-consolidating branch December 26, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants