-
Notifications
You must be signed in to change notification settings - Fork 5k
CAMEL-21269: camel-langchain4j-tokenizer fixes for the YAML DSL #15729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
6149ce6
to
db7a2bb
Compare
dsl/camel-yaml-dsl/camel-yaml-dsl/src/generated/resources/schema/camelYamlDsl.json
Show resolved
Hide resolved
- use names without dashes - refreshed catalog - added missing models - avoid creating invalid catalog files
db7a2bb
to
ba7feb4
Compare
This PR is ready, but I need to wait until Monday/Tuesday for a review from @lordrip on the resulting YAML on Kaoto's end. I want to play safe because I need to backport this to 4.8 as well. |
You should also ping @mgubaidullin as it can affect Camel Karavan |
Absolutely. I couldn't reproduce w/ the existing version of Karavan, but even if it got everything correctly, the generated YAML would still be wrong. It's on my TODO list for next week to figure out if/how Karavan is affected so I can pinpoint exactly where/how we need to fix any code relying on the incorrect model. |
I've just confirmed that the YAML itself is functional. Now I'll work with the users / tooling creators to make sure they can leverage the new EIP. Let's merge this to make it easily available for others. |
This is a more more comprehensive fix for the
tokenizer
support for the YAML DSL. There were quite a few problems in the model files that prevented it from being used with YAML (thus affecting any sub-project or project relying on this).Although it's relatively big due to the regen of a few files, all the changes are backwards compatible and anyone using it with the Java DSL should not have to change any code.