Skip to content

CAMEL-21269: camel-langchain4j-tokenizer fixes for the YAML DSL #15729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

orpiske
Copy link
Contributor

@orpiske orpiske commented Sep 26, 2024

This is a more more comprehensive fix for the tokenizer support for the YAML DSL. There were quite a few problems in the model files that prevented it from being used with YAML (thus affecting any sub-project or project relying on this).

Although it's relatively big due to the regen of a few files, all the changes are backwards compatible and anyone using it with the Java DSL should not have to change any code.

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

- use names without dashes
- refreshed catalog
- added missing models
- avoid creating invalid catalog files
@orpiske orpiske force-pushed the ci-camel-4-camel-21269-v2 branch from db7a2bb to ba7feb4 Compare September 26, 2024 17:59
@orpiske orpiske marked this pull request as draft September 27, 2024 12:01
@orpiske
Copy link
Contributor Author

orpiske commented Sep 27, 2024

This PR is ready, but I need to wait until Monday/Tuesday for a review from @lordrip on the resulting YAML on Kaoto's end. I want to play safe because I need to backport this to 4.8 as well.

@davsclaus
Copy link
Contributor

You should also ping @mgubaidullin as it can affect Camel Karavan

@orpiske
Copy link
Contributor Author

orpiske commented Sep 27, 2024

You should also ping @mgubaidullin as it can affect Camel Karavan

Absolutely. I couldn't reproduce w/ the existing version of Karavan, but even if it got everything correctly, the generated YAML would still be wrong.

It's on my TODO list for next week to figure out if/how Karavan is affected so I can pinpoint exactly where/how we need to fix any code relying on the incorrect model.

@orpiske orpiske marked this pull request as ready for review October 1, 2024 10:10
@orpiske
Copy link
Contributor Author

orpiske commented Oct 1, 2024

I've just confirmed that the YAML itself is functional. Now I'll work with the users / tooling creators to make sure they can leverage the new EIP.

Let's merge this to make it easily available for others.

@orpiske orpiske merged commit 2649814 into apache:main Oct 1, 2024
4 checks passed
@orpiske orpiske deleted the ci-camel-4-camel-21269-v2 branch October 1, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants