CAMEL-14326 Update to introduce the camel-qute component #3605
Conversation
components/camel-qute/src/main/java/org/apache/camel/component/qute/QuteEndpoint.java
Outdated
Show resolved
Hide resolved
components/camel-qute/src/test/java/org/apache/camel/component/qute/QuteTest.java
Outdated
Show resolved
Hide resolved
|
Also please fix the codestyle by running the build with -Psourcecheck. I do believe you need to completely rebuild camel with 3.2.0-SNAPSHOT first |
...s/camel-qute/src/generated/java/org/apache/camel/component/qute/QuteComponentConfigurer.java
Show resolved
Hide resolved
| public class QuteComponent extends DefaultComponent { | ||
|
|
||
| @Metadata(label = "advanced") | ||
| private Engine quarkusEngine; |
There was a problem hiding this comment.
This should be named quteEngine
| Reader reader = getEncoding() != null ? new InputStreamReader(in, getEncoding()) : new InputStreamReader(in); | ||
| return reader; | ||
| } catch (Exception e) { | ||
| log.warn("can not load template " + path + " due to " + e); |
| | *basicPropertyBinding* (advanced) | Whether the endpoint should use basic property binding (Camel 2.x) or the newer property binding with additional capabilities | false | boolean | ||
| | *synchronous* (advanced) | Sets whether synchronous processing should be strictly used, or Camel is allowed to use asynchronous processing (if supported). | false | boolean | ||
| |=== | ||
| // endpoint options: END |
There was a problem hiding this comment.
It would be good to add a new section with one or two examples to the docs
There was a problem hiding this comment.
yeah, I will add the examples.
|
@zhfeng let us know when you have the last bits done so we can get this new component merged |
|
Thanks @davsclaus - I just added the example section and re-generate the files. |
|
@oscerd @lburgazzoli oh I wonder if we merge this to camel repo, and have a dependency on quarkus-qute, and then we have a camel-quarkus extension for this component, and then we wont end up with a circular quakus dependency problem. Or a N-1 problem. eg camel-qute uses quarkus 1.2.1, and then quarkus 1.3.0 is released, and we want to release camel-quarkus with that version, and before we could just do it, now we may need to release camel first to pickup quarkus 1.3.0, and then thereafter only camel-quarkus. So maybe camel-qute should be moved to camel-quarkus and be only there? |
|
I think it makes sense to have it in camel-quarkus. You're right |
|
yeah, there is also an issue with Qute support in camel-quarkus. So I think it should be OK to move there. |
|
I close this PR and move the camel-qute component to the camel-quarkus. |
https://issues.apache.org/jira/browse/CAMEL-14326
The following work could be to support the ValueResolver, Inject beans, customs tags and etc.