Stop storing the columns in the dynamic CsvMarshaller #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efine the columns. This allows the marshaller to be reused for asymmetric records.
phantomjinx
pushed a commit
to phantomjinx/camel
that referenced
this pull request
Apr 11, 2019
CAMEL-13284: camel-box - Fix error "Did not find balanced marker at ..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the CsvMarshaller (no fixed columns) is used in a router that dynamically receives different (asymmetric) records from the consumer, the columns was always being added in a
LinkedHashSet. This generates additional empty columns in the resulting csv entry.My proposal is always use the map structure, allowing the marshaller to be reused.
A new test verifies if different maps can be used using the same marshaller without extra columns being generated.