[CAMEL-18156] Add support for hyperledger-aries #7973

tdiesler · 2022-07-05T09:04:02Z

No description provided.

github-actions · 2022-07-05T09:04:48Z

⚠️ This PR changes Camel components and will be tested automatically.

oscerd

Seems good, only minor findings related to ASF headers and version

oscerd · 2022-07-05T09:36:35Z

...l-catalog/src/generated/resources/org/apache/camel/catalog/components/hyperledger-aries.json

+    "title": "Aries",
+    "description": "Access market data and trade on Bitcoin and Altcoin exchanges.",
+    "deprecated": false,
+    "firstVersion": "3.17.0",


First version should be 3.19.0 I suppose, because 3.18.0 is on vote already

oscerd · 2022-07-05T09:38:17Z

...onents/camel-hyperledger-aries/src/main/java/org/apache/camel/component/aries/Constants.java

@@ -0,0 +1,44 @@
+/*-
+ * #%L


This section should be removed from the license header.

These headers are generated with the maven plugin. I suppose you don't manually maintain license headers across all files. I can remove all headers with plugin and perhaps then regenerate in the way you want it, but how would I do that?

oscerd · 2022-07-05T09:38:31Z

...erledger-aries/src/main/java/org/apache/camel/component/aries/HyperledgerAriesComponent.java

@@ -0,0 +1,152 @@
+/*-
+ * #%L


oscerd · 2022-07-05T09:38:44Z

...dger-aries/src/main/java/org/apache/camel/component/aries/HyperledgerAriesConfiguration.java

@@ -0,0 +1,101 @@
+/*-
+ * #%L


oscerd · 2022-07-05T09:38:54Z

...perledger-aries/src/main/java/org/apache/camel/component/aries/HyperledgerAriesEndpoint.java

@@ -0,0 +1,101 @@
+/*-
+ * #%L


oscerd · 2022-07-05T09:39:09Z

...perledger-aries/src/main/java/org/apache/camel/component/aries/HyperledgerAriesProducer.java

@@ -0,0 +1,112 @@
+/*-


github-actions · 2022-07-05T09:50:18Z

❌ Finished component verification: 1 component(s) test failed out of 2 component(s) tested

tdiesler · 2022-07-12T08:22:00Z

These headers are generated with the maven plugin. I suppose you don't manually maintain license headers across all files. I can remove all headers with plugin and perhaps then regenerate in the way you want it, but how would I do that?

Anything I can do to unlock this?

zhfeng · 2022-07-12T08:27:12Z

@tdiesler maybe you can run mvn -Plicense license:format on the hyperledger-aries component?

tdiesler · 2022-07-12T08:37:29Z

@zhfeng Merci, that seems to have worked

oscerd · 2022-07-12T08:37:42Z

We need to check how the plugin manages the license. But not your fault, so you could ignore my comment.

tdiesler · 2022-07-12T11:46:11Z

checkstyle passes for me locally

mvn -Dcheckstyle.failOnViolation=true checkstyle:checkstyle
...
[INFO] --- maven-checkstyle-plugin:3.1.2:checkstyle (default-cli) @ camel-hyperledger-aries ---
[INFO] Starting audit...
Audit done.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS

zhfeng · 2022-07-12T12:15:25Z

The CI failure looks like not related to code styles. I think it should be good.

ERROR] Failed to execute goal on project camel-allcomponents: Could not resolve dependencies for project org.apache.camel:camel-allcomponents:pom:3.19.0-SNAPSHOT: Could not find artifact org.apache.camel:camel-hyperledger-aries:jar:3.19.0-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots/) -> [Help 1]

@tdiesler can you check the build.log on https://github.com/apache/camel/actions/runs/2655649560? The compilation error is

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project camel-hyperledger-aries: Compilation failure
[ERROR] /home/runner/work/camel/camel/components/camel-hyperledger-aries/src/main/java/org/apache/camel/component/aries/HyperledgerAriesEndpoint.java:[49,76] error: cannot find symbol
[ERROR]   symbol:   variable IDENTITY
[ERROR]   location: class Category
[ERROR] -> [Help 1]

tdiesler · 2022-07-12T14:16:21Z

@zhfeng It's here https://github.com/tdiesler/camel/blob/CAMEL-18156/core/camel-api/src/generated/java/org/apache/camel/Category.java#L55

Perhaps that file is indeed generated and I should define that new category elsewhere?

zhfeng · 2022-07-12T14:45:27Z

@tdiesler I think we need to add IDENTITY in https://github.com/apache/camel/blob/main/tooling/spi-annotations/src/main/java/org/apache/camel/Category.java

github-actions · 2022-07-12T16:02:03Z

❌ Finished component verification: 3 component(s) test failed out of 5 component(s) tested

github-actions · 2022-07-12T16:40:26Z

❌ Finished component verification: 3 component(s) test failed out of 5 component(s) tested

github-actions · 2022-07-13T07:40:01Z

❌ Finished component verification: 1 component(s) test failed out of 2 component(s) tested

tdiesler · 2022-07-13T08:54:04Z

This is now failing for some unknown reason

[INFO] Running org.apache.camel.converter.aries.ConnectionReceiveInvitationFilterConverterTest
[WARNING] Tests run: 8, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 0.523 s - in org.apache.camel.converter.aries.ConnectionReceiveInvitationFilterConverterTest
[INFO] Running org.apache.camel.converter.aries.SchemaSendRequestConverterTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 s - in org.apache.camel.converter.aries.SchemaSendRequestConverterTest
[INFO] Running org.apache.camel.converter.aries.V1CredentialFreeOfferRequestConverterTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.008 s - in org.apache.camel.converter.aries.V1CredentialFreeOfferRequestConverterTest
[INFO] 
[INFO] Results:
[INFO] 
[WARNING] Tests run: 10, Failures: 0, Errors: 0, Skipped: 6

oscerd · 2022-07-13T10:08:44Z

I just noticed that the library is not on Maven central. Is that for a particular reason? We already had a lot of troubles with 3rd party Maven repositories like Atlassian.. So I'd really prefer to have the lib on Maven central.

tdiesler · 2022-07-13T10:22:08Z

Do you mean the nessus-aries component? Like nessus-ipfs, nessus-xchange, they are published to the redhat 3rd party repository, for which I have access. I've never published anything on central, so far.

oscerd · 2022-07-13T10:26:02Z

Yes, I mean 3rd party repositories in general. All of them are less reliable than central. It's not really a problem, but at some point I'd move the libraries there

github-actions · 2022-07-13T10:52:41Z

❌ Finished component verification: 1 component(s) test failed out of 2 component(s) tested

tdiesler · 2022-07-13T11:29:14Z

sure, we can do that when needed

github-actions · 2022-07-13T15:15:04Z

✔️ Finished component verification: 0 component(s) test failed out of 2 component(s) tested

github-actions · 2022-07-13T16:39:56Z

✔️ Finished component verification: 0 component(s) test failed out of 3 component(s) tested

oscerd · 2022-07-13T17:14:28Z

I'll try to merge this week.

tdiesler · 2022-07-13T18:03:14Z

This is now failing for some unknown checkstyle issue

oscerd · 2022-07-14T11:07:04Z

Maybe try to rebase on main

github-actions · 2022-07-14T11:19:30Z

✔️ Finished component verification: 0 component(s) test failed out of 3 component(s) tested

github-actions bot added catalog components core docs dsl labels Jul 5, 2022

tdiesler changed the title ~~Camel 18156~~ [CAMEL-18156] Add support for hyperledger-aries Jul 5, 2022

oscerd requested changes Jul 5, 2022

View reviewed changes

tdiesler force-pushed the CAMEL-18156 branch from 54bf2e8 to a9ac4c7 Compare July 5, 2022 13:31

tdiesler force-pushed the CAMEL-18156 branch 2 times, most recently from 370cf0f to 1d43092 Compare July 12, 2022 08:36

oscerd approved these changes Jul 12, 2022

View reviewed changes

tdiesler force-pushed the CAMEL-18156 branch from 1d43092 to 96d6ad1 Compare July 12, 2022 09:52

tdiesler force-pushed the CAMEL-18156 branch from 96d6ad1 to c500c61 Compare July 12, 2022 15:00

github-actions bot added the tooling label Jul 12, 2022

tdiesler force-pushed the CAMEL-18156 branch from c500c61 to 2a25ce6 Compare July 12, 2022 15:38

tdiesler force-pushed the CAMEL-18156 branch from 2a25ce6 to d61494c Compare July 13, 2022 06:38

tdiesler force-pushed the CAMEL-18156 branch from d61494c to bab6766 Compare July 13, 2022 10:05

tdiesler force-pushed the CAMEL-18156 branch from bab6766 to d63f340 Compare July 13, 2022 14:11

oscerd approved these changes Jul 13, 2022

View reviewed changes

tdiesler added 2 commits July 14, 2022 12:15

[CAMEL-18156] Add support for hyperledger-aries

6328e20

Fix checkstyle for GoogleSecretManagerPropertiesFunction

0fe39c3

tdiesler force-pushed the CAMEL-18156 branch from e4a1d48 to 0fe39c3 Compare July 14, 2022 10:15

oscerd merged commit aa7549b into apache:main Jul 15, 2022

tdiesler deleted the CAMEL-18156 branch July 15, 2022 11:38

[CAMEL-18156] Add support for hyperledger-aries #7973

[CAMEL-18156] Add support for hyperledger-aries #7973

Uh oh!

Conversation

tdiesler commented Jul 5, 2022

Uh oh!

github-actions bot commented Jul 5, 2022

Uh oh!

oscerd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 5, 2022

Uh oh!

tdiesler commented Jul 12, 2022

Uh oh!

zhfeng commented Jul 12, 2022

Uh oh!

tdiesler commented Jul 12, 2022

Uh oh!

oscerd commented Jul 12, 2022

Uh oh!

tdiesler commented Jul 12, 2022

Uh oh!

zhfeng commented Jul 12, 2022

Uh oh!

tdiesler commented Jul 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhfeng commented Jul 12, 2022

Uh oh!

github-actions bot commented Jul 12, 2022

Uh oh!

github-actions bot commented Jul 12, 2022

Uh oh!

github-actions bot commented Jul 13, 2022

Uh oh!

tdiesler commented Jul 13, 2022

Uh oh!

oscerd commented Jul 13, 2022

Uh oh!

tdiesler commented Jul 13, 2022

Uh oh!

oscerd commented Jul 13, 2022

Uh oh!

github-actions bot commented Jul 13, 2022

Uh oh!

tdiesler commented Jul 13, 2022

Uh oh!

github-actions bot commented Jul 13, 2022

Uh oh!

github-actions bot commented Jul 13, 2022

Uh oh!

oscerd commented Jul 13, 2022

Uh oh!

tdiesler commented Jul 13, 2022

Uh oh!

oscerd commented Jul 14, 2022

Uh oh!

github-actions bot commented Jul 14, 2022

Uh oh!

Uh oh!

tdiesler commented Jul 12, 2022 •

edited

Loading