CASSANDRA-18662: Fix cassandra-analytics-core-example #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankgh
commented
Jul 11, 2023
|
|
||
| if (!addedColumns.isEmpty()) | ||
| { | ||
| df = df.drop(addedColumns.toArray(new String[0])); |
There was a problem hiding this comment.
remove the columns from the schema, so we can validate.
This commit fixes the `SampleCassandraJob` available under the `cassandra-analytics-core-example` subproject.
The `sidecarClient` field in `SidecarDataTransferApi` is declared as transient, this is causing NPEs coming from executors while trying to perform an SSTable upload. This commit completely avoids serializing the `dataTransferApi` field in the `CassandraBulkWriterContext`, and lazily initializing it during the `transfer()` method invocation. We guard the initialization to a single thread by making the `tranfer()` method synchronized. The `SidecarDataTransferApi` can be recreated when needed using the already serialized `clusterInfo`, `jobInfo`, and `conf` fields.
|
Closed via 69766bc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the
SampleCassandraJobavailable under thecassandra-analytics-core-examplesubproject.