Skip to content

Conversation

Claudenw
Copy link

@Claudenw Claudenw commented Nov 6, 2023

Files with unapproved licenses:
/home/claude/apache/cassandra-java-driver/.gitignore
/home/claude/apache/cassandra-java-driver/core/src/main/resources/META-INF/services/reactor.blockhound.integration.BlockHoundIntegration
/home/claude/apache/cassandra-java-driver/core/src/test/resources/insights/duplicate-dependencies.txt
/home/claude/apache/cassandra-java-driver/core/src/test/resources/insights/netty-dependency-optional.txt
/home/claude/apache/cassandra-java-driver/core/src/test/resources/insights/netty-dependency.txt
/home/claude/apache/cassandra-java-driver/core/src/test/resources/insights/ordered-dependencies.txt
/home/claude/apache/cassandra-java-driver/core/src/test/resources/insights/test-dependencies.txt
/home/claude/apache/cassandra-java-driver/integration-tests/src/test/resources/META-INF/services/com.datastax.oss.driver.api.mapper.result.MapperResultProducerService
/home/claude/apache/cassandra-java-driver/manual/.nav
/home/claude/apache/cassandra-java-driver/manual/core/dse/.nav
/home/claude/apache/cassandra-java-driver/manual/core/dse/graph/.nav
/home/claude/apache/cassandra-java-driver/manual/core/dse/graph/fluent/.nav
/home/claude/apache/cassandra-java-driver/manual/core/statements/.nav
/home/claude/apache/cassandra-java-driver/manual/developer/.nav
/home/claude/apache/cassandra-java-driver/manual/developer/common/.nav
/home/claude/apache/cassandra-java-driver/manual/mapper/.nav
/home/claude/apache/cassandra-java-driver/manual/mapper/daos/.nav
/home/claude/apache/cassandra-java-driver/manual/query_builder/.nav
/home/claude/apache/cassandra-java-driver/manual/query_builder/schema/.nav
/home/claude/apache/cassandra-java-driver/mapper-processor/src/main/resources/META-INF/services/javax.annotation.processing.Processor
/home/claude/apache/cassandra-java-driver/test-infra/src/main/resources/client.crt
/home/claude/apache/cassandra-java-driver/test-infra/src/main/resources/client.key

I believe all of the above files are acceptable.

Copy link
Contributor

@hhughes hhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hhughes hhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue parsing the Jenkinsfile (comments should be c-like)

Errors encountered validating Jenkinsfile:
WorkflowScript: 2: unexpected char: '#' @ line 2, column 1.
   # Licensed to the Apache Software Foundation (ASF) under one
   ^

@hhughes
Copy link
Contributor

hhughes commented Nov 7, 2023

I've opened #1802 which has a properly formatted Jenkinsfile

# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per @michaelsembwever - link - is it correct to add a ASF license to this file which already has a 3rd-party license header?

@hhughes
Copy link
Contributor

hhughes commented Nov 10, 2023

Please close in favor of #1823 (which retains original contributor credit)

@absurdfarce
Copy link
Contributor

Closing based on quick conversation with @Claudenw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants