Skip to content

Conversation

absurdfarce
Copy link
Contributor

@absurdfarce absurdfarce commented Feb 4, 2025

Text used for entries wasn't taken from a uniform source. In some cases I used the text from the JIRA ticket and in other cases I used the text from the PR; in each case my goal was to select the text that provided the most detailed explanation about what the change was doing.

- [bug] JAVA-3057: Allow decoding a UDT that has more fields than expected
- [improvement] CASSJAVA-52: Bring java-driver-shaded-guava into the repo as a submodule
- [bug] CASSJAVA-2: TableMetadata#describe produces invalid CQL when a type of a column is a vector
- [bug] JAVA-3051: Memory leak
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kinda thinking we might want some additional detail on this one; I don't want people seeing this and thinking there was some kind of broad-based memory leak in the driver

Copy link
Contributor

@tolbertam tolbertam Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, that sticks out a bit! Memory leak!? What?

maybe change to "Fix memory leak in DefaultLoadBalancingPolicy.responseTimes"

It looks like the issue probably would have only impacted customers of AWS Keyspaces which treats nodes in such a way that it generates different node entries on every control connection refresh.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very much agreed @tolbertam. I'm gonna take a pass at fixing the verbiage here.

FTR this specific issue isn't explicitly connected to AWS Keyspaces. Apps using Keyspaces were more likely to see it because of the reconnect loop discussed elsewhere in the ticket but in theory any driver app could see this issue.

@tolbertam tolbertam self-requested a review February 4, 2025 21:38
@jahstreet
Copy link
Contributor

Thx for putting it all together!🙆‍♂️

@absurdfarce
Copy link
Contributor Author

Updated language to something based on @tolbertam 's recommendation. @tolbertam and @jahstreet can you guys take another quick look and make sure you're good with this?

@absurdfarce absurdfarce merged commit 610b91b into apache:4.x Feb 6, 2025
@absurdfarce absurdfarce deleted the 4190-changelog branch February 6, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants