-
Notifications
You must be signed in to change notification settings - Fork 885
Changelog updates for 4.19.0 #2009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
changelog/README.md
Outdated
- [bug] JAVA-3057: Allow decoding a UDT that has more fields than expected | ||
- [improvement] CASSJAVA-52: Bring java-driver-shaded-guava into the repo as a submodule | ||
- [bug] CASSJAVA-2: TableMetadata#describe produces invalid CQL when a type of a column is a vector | ||
- [bug] JAVA-3051: Memory leak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm kinda thinking we might want some additional detail on this one; I don't want people seeing this and thinking there was some kind of broad-based memory leak in the driver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, that sticks out a bit! Memory leak!? What?
maybe change to "Fix memory leak in DefaultLoadBalancingPolicy.responseTimes"
It looks like the issue probably would have only impacted customers of AWS Keyspaces which treats nodes in such a way that it generates different node entries on every control connection refresh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much agreed @tolbertam. I'm gonna take a pass at fixing the verbiage here.
FTR this specific issue isn't explicitly connected to AWS Keyspaces. Apps using Keyspaces were more likely to see it because of the reconnect loop discussed elsewhere in the ticket but in theory any driver app could see this issue.
Thx for putting it all together!🙆♂️ |
Updated language to something based on @tolbertam 's recommendation. @tolbertam and @jahstreet can you guys take another quick look and make sure you're good with this? |
f41db98
to
83b3304
Compare
Text used for entries wasn't taken from a uniform source. In some cases I used the text from the JIRA ticket and in other cases I used the text from the PR; in each case my goal was to select the text that provided the most detailed explanation about what the change was doing.