Skip to content

Modified project details - role based users in projects #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 24, 2020

Conversation

Pearl1594
Copy link
Contributor

Added details with respect to support for:

  • multiple project admins
  • project roles to restrict users from performing operations at project level

@Pearl1594
Copy link
Contributor Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145

Build Log Output:

No log errors found to report.

@Pearl1594 Pearl1594 force-pushed the proj-roleBased-users branch from 59da762 to f903066 Compare August 11, 2020 04:52
@Pearl1594
Copy link
Contributor Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145

Build Log Output:

No log errors found to report.

@Pearl1594 Pearl1594 force-pushed the proj-roleBased-users branch from f903066 to 948217f Compare August 11, 2020 05:04
@Pearl1594
Copy link
Contributor Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145

Build Log Output:

No log errors found to report.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor remarks

invitation to any email address.

#. To view and manage the invitations you have sent, return to this tab.
5. To view and manage the invitations you have sent, return to this tab.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should th 5. here be a #.?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

by the Account level role. If there are no specific deny rules in the
project role, it would again fallback onto the account-level role to decide
whether the user has permissions to perform a specific action.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would like to see a second note to make clear that a user's rights can not be widened in comparison to their account role but only restricted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added relevant details

@Pearl1594
Copy link
Contributor Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145

Build Log Output:

No log errors found to report.

@Pearl1594
Copy link
Contributor Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145

Build Log Output:

No log errors found to report.

Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice piece of documentation, thanks @Pearl1594! I raised a few points to change.

Bear in mind that I am not a native English speaker, therefore, some of my suggestions might not be ideal.

it is possible to restrict access of users in a project, i.e., in
addition to account-level roles, one can further restrict access to
operations (or APIs) by associating a project-level role to the
user or account. However, If an account has already been added, one will not
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, If ➡️ However, if

@GabrielBrascher
Copy link
Member

@Pearl1594 @DaanHoogland Is this still draft or can we put it into "Ready for review"?

@Pearl1594 Pearl1594 marked this pull request as ready for review August 11, 2020 12:35
@Pearl1594
Copy link
Contributor Author

@GabrielBrascher I've addressed your comments. Thanks for pointing them out.

@Pearl1594
Copy link
Contributor Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145

Build Log Output:

No log errors found to report.

Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rohityadavcloud pushed a commit to apache/cloudstack that referenced this pull request Aug 13, 2020
Enabling Role Based users in projects
Primate PR related to the FR: apache/cloudstack-primate#382
Doc PR: apache/cloudstack-documentation#145

Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>
@rohityadavcloud rohityadavcloud merged commit 316861b into apache:master Sep 24, 2020
@rohityadavcloud rohityadavcloud added this to the 4.15 milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants