-
Notifications
You must be signed in to change notification settings - Fork 118
Modified project details - role based users in projects #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified project details - role based users in projects #145
Conversation
requesting docbuild |
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145 Build Log Output: No log errors found to report. |
59da762
to
f903066
Compare
requesting docbuild |
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145 Build Log Output: No log errors found to report. |
f903066
to
948217f
Compare
requesting docbuild |
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145 Build Log Output: No log errors found to report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two minor remarks
source/adminguide/projects.rst
Outdated
invitation to any email address. | ||
|
||
#. To view and manage the invitations you have sent, return to this tab. | ||
5. To view and manage the invitations you have sent, return to this tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should th 5.
here be a #.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
by the Account level role. If there are no specific deny rules in the | ||
project role, it would again fallback onto the account-level role to decide | ||
whether the user has permissions to perform a specific action. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would like to see a second note to make clear that a user's rights can not be widened in comparison to their account role but only restricted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added relevant details
requesting docbuild |
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145 Build Log Output: No log errors found to report. |
requesting docbuild |
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145 Build Log Output: No log errors found to report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice piece of documentation, thanks @Pearl1594! I raised a few points to change.
Bear in mind that I am not a native English speaker, therefore, some of my suggestions might not be ideal.
source/adminguide/projects.rst
Outdated
it is possible to restrict access of users in a project, i.e., in | ||
addition to account-level roles, one can further restrict access to | ||
operations (or APIs) by associating a project-level role to the | ||
user or account. However, If an account has already been added, one will not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, If
➡️ However, if
@Pearl1594 @DaanHoogland Is this still draft or can we put it into "Ready for review"? |
@GabrielBrascher I've addressed your comments. Thanks for pointing them out. |
requesting docbuild |
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr145 Build Log Output: No log errors found to report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Enabling Role Based users in projects Primate PR related to the FR: apache/cloudstack-primate#382 Doc PR: apache/cloudstack-documentation#145 Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com> Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>
Added details with respect to support for: