Skip to content

Virtual Router Service Offering #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Feb 14, 2022
Merged

Virtual Router Service Offering #157

merged 24 commits into from
Feb 14, 2022

Conversation

ustcweizhou
Copy link
Contributor

content to be added

link to apache/cloudstack#3946

@ustcweizhou ustcweizhou changed the title Add header for router service offering Virtual Router Service Offering Sep 21, 2020
@rohityadavcloud
Copy link
Member

ping @ustcweizhou are we expecting the content?

@rohityadavcloud
Copy link
Member

ping @ustcweizhou

@sureshanaparti sureshanaparti added this to the 4.16.1 milestone Jan 6, 2022
@sureshanaparti sureshanaparti changed the base branch from main to 4.16 February 9, 2022 13:41
@sureshanaparti
Copy link
Contributor

Hi @ustcweizhou Please fix the conflicts. Are you adding the content, and will this be ready for 4.16.1?

sureshanaparti
sureshanaparti reviewed Feb 9, 2022
View reviewed changes
@weizhouapache weizhouapache marked this pull request as ready for review February 11, 2022 11:01
@weizhouapache
Copy link
Member

@blueorangutan docbuild

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/157. (SL-JID 196)

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/157. (SL-JID 197)

@weizhouapache
Copy link
Member

@blueorangutan docbuild

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/157. (SL-JID 198)

@weizhouapache
Copy link
Member

@blueorangutan docbuild

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/157. (SL-JID 199)

@weizhouapache
Copy link
Member

@sureshanaparti this is ready for review

http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/157/adminguide/service_offerings.html#changing-the-default-system-offering-for-virtual-routers

DaanHoogland
DaanHoogland approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking about "lidwoorden" @weizhouapache , but looks good

weizhouapache and others added 2 commits February 11, 2022 15:48
@weizhouapache @DaanHoogland
Update source/adminguide/service_offerings.rst
10300a1 
Co-authored-by: dahn <daan.hoogland@gmail.com>
@weizhouapache @DaanHoogland
Update source/adminguide/service_offerings.rst
d30d6b4 
Co-authored-by: dahn <daan.hoogland@gmail.com>
weizhouapache and others added 11 commits February 11, 2022 15:48
@weizhouapache @DaanHoogland
Update source/adminguide/service_offerings.rst
fd0c5cf 
Co-authored-by: dahn <daan.hoogland@gmail.com>
@weizhouapache @DaanHoogland
Update source/adminguide/service_offerings.rst
d4e52c3 
Co-authored-by: dahn <daan.hoogland@gmail.com>
@weizhouapache @DaanHoogland
Update source/adminguide/networking/manage_guest_networks.rst
e13c3b1 
Co-authored-by: dahn <daan.hoogland@gmail.com>
@weizhouapache @DaanHoogland
Update source/adminguide/networking/manage_guest_networks.rst
12000e6 
Co-authored-by: dahn <daan.hoogland@gmail.com>
@weizhouapache @DaanHoogland
Update source/adminguide/networking/manage_guest_networks.rst
d6756b9 
Co-authored-by: dahn <daan.hoogland@gmail.com>
@weizhouapache @DaanHoogland
Update source/adminguide/service_offerings.rst
81f0bc5 
Co-authored-by: dahn <daan.hoogland@gmail.com>
@weizhouapache @DaanHoogland
Update source/adminguide/service_offerings.rst
be2d547 
Co-authored-by: dahn <daan.hoogland@gmail.com>
@weizhouapache @DaanHoogland
Update source/adminguide/service_offerings.rst
1eb5f7a 
Co-authored-by: dahn <daan.hoogland@gmail.com>
@weizhouapache @DaanHoogland
Update source/adminguide/service_offerings.rst
3d1df4a 
Co-authored-by: dahn <daan.hoogland@gmail.com>
@weizhouapache @DaanHoogland
Update source/adminguide/service_offerings.rst
83252e0 
Co-authored-by: dahn <daan.hoogland@gmail.com>
@weizhouapache @DaanHoogland
Update source/adminguide/service_offerings.rst
f86bef4 
Co-authored-by: dahn <daan.hoogland@gmail.com>
@weizhouapache
Copy link
Member

thanks @DaanHoogland for view !
pr is updated

@weizhouapache
Copy link
Member

@blueorangutan docbuild

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/157. (SL-JID 200)

sureshanaparti
sureshanaparti reviewed Feb 14, 2022
View reviewed changes
@weizhouapache @sureshanaparti
Update source/adminguide/networking/manage_guest_networks.rst
f0def94 
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
sureshanaparti
sureshanaparti reviewed Feb 14, 2022
View reviewed changes
sureshanaparti
sureshanaparti reviewed Feb 14, 2022
View reviewed changes
sureshanaparti
sureshanaparti reviewed Feb 14, 2022
View reviewed changes
sureshanaparti
sureshanaparti reviewed Feb 14, 2022
View reviewed changes
weizhouapache and others added 4 commits February 14, 2022 11:07
@weizhouapache @sureshanaparti
Update source/adminguide/service_offerings.rst
df747ae 
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
@weizhouapache @sureshanaparti
Update source/adminguide/service_offerings.rst
c8fe781 
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
@weizhouapache @sureshanaparti
Update source/adminguide/service_offerings.rst
f03b01e 
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
@weizhouapache @sureshanaparti
Update source/adminguide/service_offerings.rst
b0caccc 
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
@weizhouapache
Copy link
Member

@blueorangutan docbuild

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/157. (SL-JID 201)

@sureshanaparti sureshanaparti merged commit ba58176 into apache:4.16 Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@weizhouapache weizhouapache weizhouapache left review comments

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees

@weizhouapache weizhouapache

Labels
None yet
Projects
No open projects
Apache CloudStack 4.16.1
Status: Done
Milestone
4.16.1
Development

Successfully merging this pull request may close these issues.
6 participants
@ustcweizhou @rohityadavcloud @sureshanaparti @weizhouapache @blueorangutan @DaanHoogland