Skip to content

VM Dynamic Scaling granular options to enabling or disabling #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2021

Conversation

harikrishna-patnala
Copy link
Contributor

Added the new option that are available to configure dynamic scaling on VM.
This is related to PR apache/cloudstack#4643

@DaanHoogland
Copy link
Contributor

can a native speaker of English do a review of this @harikrishna-patnala ? If you can find one. I'm not confident to do it but i think some re-phrasings are needed.

@nvazquez
Copy link
Contributor

@blueorangutan docbuild

@nvazquez
Copy link
Contributor

Ping for review @DaanHoogland @rhtyd

@harikrishna-patnala
Copy link
Contributor Author

I thought this PR was merged, apologies my bad. I'll add few reviewers for technical review as well.

- While deploying a VM, user or admin needs to mark Dynamic Scaling Enabled to true.
By default the value of Dynamic Scaling Enabled is set to true.

If any of the above settings are false then VM cannot be configured as dynamically scalable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If any of the above settings are false then VM cannot be configured as dynamically scalable.
If any of the above settings are false, then VM cannot be scaled dynamically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading of this section is 'Configuring dynamic scaling', so I've worded it like this to mention how the VM will be configured.


- Template from which VM is created needs to have Xen tools (for XenServer hosts)
or VMware Tools (for VMware hosts) and while registering the template should be
marked as Dynamically Scalable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enabled with Dynamic Scaling.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now used the word 'flag' with its actual name on the UI form instead of 'option' in all the cases as well.

@harikrishna-patnala harikrishna-patnala force-pushed the VMDynamicScalingGranularOptions branch from b243c49 to ab7be4c Compare October 18, 2021 04:38
@harikrishna-patnala harikrishna-patnala force-pushed the VMDynamicScalingGranularOptions branch from ab7be4c to ab9893a Compare October 18, 2021 04:43
@harikrishna-patnala
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@harikrishna-patnala a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/186. (SL-JID 160)

@sureshanaparti
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/186. (SL-JID 162)

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc LGTM

@rohityadavcloud rohityadavcloud merged commit 2c9d1d1 into main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants