-
Notifications
You must be signed in to change notification settings - Fork 119
MySQL sql_mode change #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This addresses the issue apache/cloudstack#5175 |
5e44f98
to
4ff2271
Compare
@blueorangutan docbuild |
@harikrishna-patnala a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/239. (SL-JID 137) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @harikrishna-patnala, content LGTM but needs formatting
Thanks @nvazquez , fixed formatting |
@blueorangutan docbuild |
Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/239. (SL-JID 138) |
@harikrishna-patnala a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/239. (SL-JID 139) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@harikrishna-patnala |
+1 @harikrishna-patnala I think we should advise admin to just fix the global my.cnf? See install/admin section? |
@rhtyd @weizhouapache Unpopular opinion: I would not decrease strictness of sql globally if its absolutely not needed. |
I suppose with your comment @kricud, the changes can be accepted then. |
PR merged cc @GabrielBrascher |
MySQL sql_mode has changed and if the admin uses MySQL directly and wants to query tables it is advised to change the sql_mode in the corresponding session or globally.
Eg. mysql> set global sql_mode="STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION";
Query OK, 0 rows affected (0.00 sec)