Skip to content

Conversation

harikrishna-patnala
Copy link
Contributor

MySQL sql_mode has changed and if the admin uses MySQL directly and wants to query tables it is advised to change the sql_mode in the corresponding session or globally.

Eg. mysql> set global sql_mode="STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION";
Query OK, 0 rows affected (0.00 sec)

@harikrishna-patnala
Copy link
Contributor Author

This addresses the issue apache/cloudstack#5175

@harikrishna-patnala harikrishna-patnala changed the base branch from main to 4.15 September 3, 2021 03:07
@harikrishna-patnala
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@harikrishna-patnala a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/239. (SL-JID 137)

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harikrishna-patnala, content LGTM but needs formatting

Screenshot from 2021-09-03 00-36-59

@harikrishna-patnala
Copy link
Contributor Author

Thanks @nvazquez , fixed formatting

@harikrishna-patnala
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/239. (SL-JID 138)

@blueorangutan
Copy link

@harikrishna-patnala a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/239. (SL-JID 139)

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weizhouapache
Copy link
Member

@harikrishna-patnala
would it be better to add few lines for persistent mysql setting ?
users need to change /etc/mysql/my.cnfand restart mysql

@rohityadavcloud
Copy link
Member

+1

@harikrishna-patnala I think we should advise admin to just fix the global my.cnf? See install/admin section?

@kricud
Copy link

kricud commented Sep 3, 2021

@rhtyd @weizhouapache Unpopular opinion: I would not decrease strictness of sql globally if its absolutely not needed.
Someone has com to conclusion that it must be stricter globally and there probably are arguments why in context of
enabling ONLY_FULL_GROUP_BY. Approach of allowing it to each client/connection in my opinion is better.
Mentioning it in documentation in my opinion is enough.
https://www.percona.com/blog/2019/05/13/solve-query-failures-regarding-only_full_group_by-sql-mode/

@rohityadavcloud rohityadavcloud added this to the 4.15 milestone Sep 3, 2021
@rohityadavcloud
Copy link
Member

I suppose with your comment @kricud, the changes can be accepted then.

@rohityadavcloud rohityadavcloud merged commit ba570a1 into 4.15 Sep 3, 2021
@rohityadavcloud
Copy link
Member

PR merged cc @GabrielBrascher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants