Skip to content

Add a document to config footer text #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 10, 2022
Merged

Add a document to config footer text #251

merged 7 commits into from
Feb 10, 2022

Conversation

utchoang
Copy link

Related apache/cloudstack#5628.
The documentation allows configuring a footer text at the Login screen.

GabrielBrascher
GabrielBrascher approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulAngus
Copy link
Member

Inline with comment in apache/cloudstack#5628 - It would seem to me more logical for the loginFooter text to be configured next to the Footer text.
And therefore the loginFooter text explanation would move up to the same documentation area as the Footer text.

Way down in the advanced plugins section seems a very odd place for it to end up.

@rohityadavcloud rohityadavcloud added this to the 4.16.1 milestone Nov 15, 2021
@sureshanaparti
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/251. (SL-JID 177)

@sureshanaparti sureshanaparti changed the base branch from main to 4.16 February 9, 2022 13:41
@sureshanaparti
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/251. (SL-JID 191)

sureshanaparti
sureshanaparti reviewed Feb 10, 2022
View reviewed changes
@utchoang utchoang changed the base branch from 4.16 to main February 10, 2022 06:22
@utchoang utchoang changed the base branch from main to 4.16 February 10, 2022 06:22
@apache apache deleted a comment from blueorangutan Feb 10, 2022
@apache apache deleted a comment from sureshanaparti Feb 10, 2022
@utchoang
Copy link
Author

@blueorangutan docbuild

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/251. (SL-JID 193)

@sureshanaparti
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/251. (SL-JID 194)

@sureshanaparti
Copy link
Contributor

Doc looks good.

Doc-FooterTextConfig

@sureshanaparti sureshanaparti merged commit bb073a2 into apache:4.16 Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielBrascher GabrielBrascher GabrielBrascher approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees

@utchoang utchoang

Labels
None yet
Projects
No open projects
Apache CloudStack 4.16.1
Status: Done
Milestone
4.16.1
Development

Successfully merging this pull request may close these issues.
6 participants
@utchoang @PaulAngus @sureshanaparti @blueorangutan @GabrielBrascher @rohityadavcloud