-
Notifications
You must be signed in to change notification settings - Fork 119
Fix mysqldump missing 'Grave Accent' #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mysqldump missing 'Grave Accent' #255
Conversation
@blueorangutan docbuild |
@GabrielBrascher a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/255. (SL-JID 172) |
@GabrielBrascher would it be safer to use the |
@rhtyd good point, |
@blueorangutan docbuild |
@GabrielBrascher a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/255. (SL-JID 173) |
@GabrielBrascher I know only date is used in old docs. would it be better to use date and time like the following ?
|
@weizhouapache I assume that as the upgrade is a process that is done in one day it would not be needed, I don't imagine more than one backup at a day at least for the given operaiton. But it looks like a good "safety" command in case someone backs up the DB before and after the upgrade and ends up overriding the first backup. |
Updated to @weizhouapache suggestions. @blueorangutan docbuild |
@GabrielBrascher a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/255. (SL-JID 174) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Lgtm |
Fix mysqldump command in the "Database Preparation" section.
Nowadays it is:
This won't work as it is missing a grave accent (
) in ``date '+%Y-%m-%d'.
.Should be: