Skip to content

Update kvm.rst #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Update kvm.rst #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions source/installguide/hypervisor/kvm.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,19 +317,19 @@ cloudstack-agent and should already be installed.

env libvirtd_opts="-d -l"

On Ubuntu 16.04: just modify ``/etc/init/libvirt-bin.conf``
On Ubuntu 16.04: just modify ``/etc/default/libvirt-bin``

Add "-l" to the following line
Uncomment and change the following line

.. parsed-literal::

env libvirtd_opts="-d"
#env libvirtd_opts=""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhtyd better to provide possible options / recommendations. your opinion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sureshanaparti what do you mean?

Copy link
Contributor

@sureshanaparti sureshanaparti Jan 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bwsw i mean libvirtd_opts. any recommended opts here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if any, update the comment. else fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sureshanaparti I don't get. Just read several lines. It states

  1. uncomment line
  2. add "-l"
    done.
    Could you please explain what you expect?

Copy link
Contributor

@sureshanaparti sureshanaparti Jan 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bwsw Uncommenting " #env libvirtd_opts="" " and looks like " env libvirtd_opts="-l" ". I see "Add "-l" to the following line" option is missing.
libvirt-bin_2019-01-29

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sureshanaparti you may think, I'm kidding you... But I'm not. No offense, but I really, don't get what do you mean. Try use code more verbal and detailed explanation. You may also want open new PR with a better fix for that.
@rhtyd @rafaelweingartner if you understand what @sureshanaparti is talking about, please help... because I don't.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bwsw Just go through the image attached above. we may understand, else leave it. Sorry for not making you understand. Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sureshanaparti you need to re-read the change. You'll understand there is no need of any further changes.
What @bwsw can do is say something like:

Make this:
# some commented stuff
to:
something not commented


so it looks like:

.. parsed-literal::

env libvirtd_opts="-d -l"
env libvirtd_opts="-l"



Expand Down