Skip to content

kvm,snapshot: note on primary storage dependency #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2024
Merged

kvm,snapshot: note on primary storage dependency #367

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b5bf70
kvm,snapshot: note on primary storage dependency
shwstppr Dec 14, 2023
c936c17
fix
shwstppr Dec 14, 2023
d343e0d
Update source/adminguide/storage.rst
shwstppr Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions source/adminguide/storage.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,6 +957,9 @@ incremental backups are supported, every N backup is a full backup.
| Support incremental backup | No | Yes | No |
+------------------------------+------------------+------------------+-----+

.. note::
Between versions 4.17.x, 4.18.0 and 4.18.1, KVM volume snapshot backups were not full snapshots and they rely on the snapshots on the primary storage. To prevent any loss of data, care must be taken during revert operation and it must be ensured that the source primary storage snapshot file is present.

Comment on lines +961 to +962
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shwstppr, would not it be useful to guide users on how to identify the affected volumes/snapshots, vide apache/cloudstack#8034 (comment)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GutoVeronezi good idea. Though I'm not sure how to structure it.
Would you mind adding a change in the PR as you must be having better understanding on the process?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the last comment; I will put it on my tasks 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GutoVeronezi any update or should we merge this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shwstppr may be we can continue merging this and handle that steps in a different PR. @GutoVeronezi can you please raise a separate PR for that.


Volume Status
~~~~~~~~~~~~~
Expand Down