Skip to content

Conversation

sudo87
Copy link
Contributor

@sudo87 sudo87 commented Aug 28, 2025

This pr fixes: apache/cloudstack#11519

There are 3 issues

  1. 2 broken link: "Adding an ISO" and "linux-with-cloud-init":

    • Adding an ISO is fixed
    • Linux with Cloud init is no longer seen
  2. Duplicate content mentioned in the ticket "creating-a-linux-template"

    • Parent page (templates.html) rendering content from child (_create_linux.html)
    • If both pages are opened separately it may appear to have duplicate content.

📚 Documentation preview 📚: https://cloudstack-documentation--548.org.readthedocs.build/en/548/

@DaanHoogland
Copy link
Contributor

looks good @sudo87 , are you also addressing the duplicate contents issue the tcket talks about in this?

@sudo87
Copy link
Contributor Author

sudo87 commented Aug 28, 2025

I couldn't find duplicate content.

As templates.html renders child page [_create_linux.html#creating-a-linux-template] within itself. It may have given duplicate content impression.

@DaanHoogland
Copy link
Contributor

I couldn't find duplicate content.

As templates.html renders child page [_create_linux.html#creating-a-linux-template] within itself. It may have given duplicate content impression.

@ingox , speaks of these files containing the some duplicate contents:
https://docs.cloudstack.apache.org/en/latest/adminguide/templates.html#creating-a-linux-template
https://docs.cloudstack.apache.org/en/latest/adminguide/templates/_create_linux.html#creating-a-linux-template

but we can create a separate ticket for that, I just wanted to make sure so we don’t close the ticket while only half solving it.

@sudo87
Copy link
Contributor Author

sudo87 commented Aug 28, 2025

I couldn't find duplicate content.
As templates.html renders child page [_create_linux.html#creating-a-linux-template] within itself. It may have given duplicate content impression.

@ingox , speaks of these files containing the some duplicate contents: https://docs.cloudstack.apache.org/en/latest/adminguide/templates.html#creating-a-linux-template https://docs.cloudstack.apache.org/en/latest/adminguide/templates/_create_linux.html#creating-a-linux-template

but we can create a separate ticket for that, I just wanted to make sure so we don’t close the ticket while only half solving it.

Sure, I updated the pr description as well with findings.

@rohityadavcloud rohityadavcloud added this to the 4.21.0 milestone Aug 28, 2025
@sureshanaparti sureshanaparti merged commit a22c5fe into apache:main Aug 28, 2025
1 check passed
@sureshanaparti sureshanaparti deleted the fixTemplatesDoc branch August 28, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken links and duplicate content
4 participants