Skip to content

upgrade: upgrade systemvmtemplate for 4.14 #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 29, 2020
Merged

upgrade: upgrade systemvmtemplate for 4.14 #87

merged 15 commits into from
Apr 29, 2020

Conversation

rohityadavcloud
Copy link
Member

This adds upgrade/systemvmtemplate for 4.14

@rohityadavcloud
upgrade: upgrade systemvmtemplate for 4.14
f08cd29 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@rohityadavcloud rohityadavcloud added this to the 4.14.0.0 milestone Jan 9, 2020
@rohityadavcloud
Copy link
Member Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr87

Build Log Output:

No log errors found to report.

@rohityadavcloud
use latest available guest OS or other linux 64-bit
bdb5c01 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@rohityadavcloud
Copy link
Member Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr87

Build Log Output:

No log errors found to report.

@rohityadavcloud
bump version to 4.14
517e5c4 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@rohityadavcloud
Copy link
Member Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr87

Build Log Output:

No log errors found to report.

andrijapanicsb
andrijapanicsb requested changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@andrijapanicsb andrijapanicsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those below needs change.

andrijapanicsb
andrijapanicsb reviewed Jan 9, 2020
View reviewed changes
PaulAngus
PaulAngus requested changes Jan 9, 2020
View reviewed changes
Copy link
Member

@PaulAngus PaulAngus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added concern with adding requirements on users which (i think) can easily be handled by the upgrade sql.

@rohityadavcloud
address some review comments
c85cccf 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@rohityadavcloud
Copy link
Member Author

@PaulAngus @andrijapanicsb thanks for the review, the 4.13 upgrade rst file is a copy/paste of the 4.12, which was a copy/paste of 4.11...
We've been using the new upgrade path/docs as boilerplate from the upgrade doc of the version before. I think, we probably need to review the post-upgrade docs and make suitable changes. I'm not sure how much of the boilterplate is valid at all now.

@PaulAngus
Copy link
Member

We will have the new systemVM template API and UI. I suggest that we (you) need to get up to speed on how it works ASAP @rhtyd @andrijapanicsb //cc @borisstoyanov @Spaceman1984

@andrijapanicsb
Copy link
Contributor

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr87

Build Log Output:

No log errors found to report.

@andrijapanicsb
Copy link
Contributor

We will have the new systemVM template API and UI. I suggest that we (you) need to get up to speed on how it works ASAP @rhtyd @andrijapanicsb //cc @borisstoyanov @Spaceman1984

Looking forward to show&tell.

@rohityadavcloud
Copy link
Member Author

@andrijapanicsb @PaulAngus I see some changes, anything I need to do? cc @DaanHoogland

@DaanHoogland
Copy link
Contributor

source/upgrading/upgrade/upgrade-4.11.rst contains a warning about updating to the 4.11.3 templates. it seems outdated, is it @andrijapanicsb @rhtyd ?

In more generic terms it is valid for all versions. How do we handle this?

.. warning::
    If you have not registered the 4.11.3 System VM templates for your hypervisors,
    you will need to register them prior to performing the upgrade of the CloudStack
    packages. This includes those currently running a **clean** install of CloudStack 4.11.3 (ie you
    did not upgrade from another version to reach 4.11.3), you will still need to
    explicitly register the 4.11.3 System VM template(s), you will not however need
    to restart the existing system VMs.

    If you are running an instance of CloudStack 4.11.3
    that was upgraded from a the previous versions,
    you will already have explicitly registered the 4.11.3 System VM template(s) and
    need not do it again.

DaanHoogland
DaanHoogland reviewed Jan 27, 2020
View reviewed changes
@rohityadavcloud
remove jsvc, no longer used by cloudstack agents
45b32a5 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@rohityadavcloud
notes on primate and jdk11 version
e69fb1a 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@rohityadavcloud
Copy link
Member Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr87

Build Log Output:

No log errors found to report.

DaanHoogland
DaanHoogland approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending merge of other PRs; lgtm

GabrielBrascher
GabrielBrascher reviewed Jan 31, 2020
View reviewed changes
@rohityadavcloud rohityadavcloud mentioned this pull request Jan 31, 2020
Closed
GabrielBrascher
GabrielBrascher approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

andrijapanicsb
andrijapanicsb reviewed Feb 3, 2020
View reviewed changes
source/upgrading/upgrade/upgrade_notes.rst

UI Deprecation Notice
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhtyd I don't see this whole section visible anywhere (in any of the specific version upgrade docs..) - I could include it myself somewhere, but not sure where is the best place - possibly in index page?

And we should probably also add that we don't support CentOS 6 anymore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a compatibility section in the release notes.

@andrijapanicsb
Copy link
Contributor

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr87

Build Log Output:

No log errors found to report.

@rohityadavcloud
Copy link
Member Author

@andrijapanicsb should we merge this?

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr87

Build Log Output:

No log errors found to report.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr87

Build Log Output:

No log errors found to report.

andrijapanicsb
andrijapanicsb reviewed Apr 12, 2020
View reviewed changes
@andrijapanicsb
Copy link
Contributor

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr87

Build Log Output:

No log errors found to report.

@andrijapanicsb andrijapanicsb merged commit 99404f8 into apache:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@andrijapanicsb andrijapanicsb andrijapanicsb requested changes

@GabrielBrascher GabrielBrascher GabrielBrascher approved these changes

@borisstoyanov borisstoyanov Awaiting requested review from borisstoyanov

@PaulAngus PaulAngus Awaiting requested review from PaulAngus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.14.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rohityadavcloud @ACSGitBot @PaulAngus @andrijapanicsb @DaanHoogland @GabrielBrascher