-
Notifications
You must be signed in to change notification settings - Fork 1.2k
UI: Fix domain view when opening details for a specific domainid #10245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10245 +/- ##
=========================================
Coverage 15.14% 15.14%
- Complexity 11281 11283 +2
=========================================
Files 5408 5408
Lines 473767 473818 +51
Branches 57812 57823 +11
=========================================
+ Hits 71752 71764 +12
- Misses 393992 394032 +40
+ Partials 8023 8022 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested in qa with and without change.
bc6c4fc
to
b59105e
Compare
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
@vishesh92 I can see that domain page is fixed when a domain is clicked but when I click back button I'm seeing this 404 error. Can you please check it. |
I think I know why this is happening. Let me fix that. |
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
Description
This PR fixes #9893
Details
This pull request includes updates to the
DomainView.vue
component to improve data fetching and rendering logic. The most important changes include adding a condition to thetree-view
component and modifying the data fetching mechanism to watch for route parameter changes.Improvements to data fetching and rendering:
ui/src/views/iam/DomainView.vue
: Added av-else
condition to thetree-view
component to ensure it only renders when appropriate.ui/src/views/iam/DomainView.vue
: Changed thecreated
lifecycle hook to watch for changes in the route parameters and fetch data immediately when the component is created.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?