Skip to content

Conversation

vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Jan 23, 2025

Description

This PR fixes #9893

Details

This pull request includes updates to the DomainView.vue component to improve data fetching and rendering logic. The most important changes include adding a condition to the tree-view component and modifying the data fetching mechanism to watch for route parameter changes.

Improvements to data fetching and rendering:

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92 vishesh92 linked an issue Jan 23, 2025 that may be closed by this pull request
@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.14%. Comparing base (1e59f5c) to head (fcee715).
Report is 17 commits behind head on 4.19.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.19   #10245   +/-   ##
=========================================
  Coverage     15.14%   15.14%           
- Complexity    11281    11283    +2     
=========================================
  Files          5408     5408           
  Lines        473767   473818   +51     
  Branches      57812    57823   +11     
=========================================
+ Hits          71752    71764   +12     
- Misses       393992   394032   +40     
+ Partials       8023     8022    -1     
Flag Coverage Δ
uitests 4.29% <ø> (-0.01%) ⬇️
unittests 15.86% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10245 (QA-JID-524)

@DaanHoogland DaanHoogland added this to the 4.19.2 milestone Jan 23, 2025
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in qa with and without change.

@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10245 (QA-JID-525)

@harikrishna-patnala
Copy link
Contributor

@vishesh92 I can see that domain page is fixed when a domain is clicked but when I click back button I'm seeing this 404 error. Can you please check it.

image

@vishesh92
Copy link
Member Author

@vishesh92 I can see that domain page is fixed when a domain is clicked but when I click back button I'm seeing this 404 error. Can you please check it.

image

I think I know why this is happening. Let me fix that.

@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10245 (QA-JID-527)

@DaanHoogland DaanHoogland merged commit 0fbf637 into apache:4.19 Jan 30, 2025
24 of 26 checks passed
@DaanHoogland DaanHoogland deleted the fixup-domain-view branch January 30, 2025 14:55
rg9975 pushed a commit to rg9975/cloudstack that referenced this pull request Jan 31, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Opening direct URL to domain causes visual bug/glitch
5 participants