Fix NPE during account creation

[bernardodemarco]

Description

During account creation, if the log level of the com.cloud category is set to TRACE, a NPE is thrown, making it impossible to create accounts. This PR fixes this NPE.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Before applying the changes, setting the log level of the com.cloud category to TRACE caused account creation to fail due to a NPE.

After applying the changes, the NPE is no longer thrown, and accounts can be created without any issues.

[bernardodemarco]

@blueorangutan package

[blueorangutan]

@bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 15.14%. Comparing base (0a77eb7) to head (f496ff1).
Report is 10 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...c/main/java/com/cloud/user/AccountManagerImpl.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10274      +/-   ##
============================================
- Coverage     15.14%   15.14%   -0.01%     
+ Complexity    11283    11280       -3     
============================================
  Files          5408     5408              
  Lines        473823   473822       -1     
  Branches      57824    57824              
============================================
- Hits          71764    71756       -8     
- Misses       394037   394044       +7     
  Partials       8022     8022              

Flag	Coverage Δ
uitests	4.29% <ø> (ø)
unittests	15.86% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12209

[DaanHoogland]

clgtm

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[sureshanaparti]

clgtm

[blueorangutan]

[SF] Trillian test result (tid-12191)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 43237 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10274-t12191-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[borisstoyanov]

LGTM, could not reproduce the NPE