server: fix npe during start vr edge case

[shwstppr]

Description

DeploymentPlanner.addPod takes long value while
VmInstanceVO.getPodIdToDeployIn returns a Long value which can be null when the VM is never started.

Error seen while doing consecutive VPC restarts with cleanup,

java.lang.NullPointerException
        at com.cloud.network.router.NetworkHelperImpl.startVirtualRouter(NetworkHelperImpl.java:448)
        at com.cloud.network.router.NetworkHelperImpl.startRouters(NetworkHelperImpl.java:384)
        at org.apache.cloudstack.network.router.deployment.RouterDeploymentDefinition.deployVirtualRouter(RouterDeploymentDefinition.java:209)
        at com.cloud.network.element.VpcVirtualRouterElement.prepare(VpcVirtualRouterElement.java:307)
        at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepareElement(NetworkOrchestrator.java:1756)
        at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepareNic(NetworkOrchestrator.java:2129)
        at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepare(NetworkOrchestrator.java:2056)
        at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:1253)

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.15%. Comparing base (802bf5f) to head (bfe5aa7).
Report is 36 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...va/com/cloud/network/router/NetworkHelperImpl.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             4.19   #10366       +/-   ##
===========================================
+ Coverage        0   15.15%   +15.15%     
- Complexity      0    11314    +11314     
===========================================
  Files           0     5413     +5413     
  Lines           0   474671   +474671     
  Branches        0    57891    +57891     
===========================================
+ Hits            0    71941    +71941     
- Misses          0   394683   +394683     
- Partials        0     8047     +8047     

Flag	Coverage Δ
uitests	4.29% <ø> (?)
unittests	15.87% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12407

[DaanHoogland]

clgtm

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12387)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50754 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10366-t12387-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File