Skip to content

Keeping consistency with other error messages. #11649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Keeping consistency with other error messages. #11649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cd947b
Keeping consistency with other error messages.
Sep 16, 2025
2aaf506
Apply suggestions from code review
daviftorres Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ava/org/apache/cloudstack/api/command/user/loadbalancer/UpdateLBHealthCheckPolicyCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public long getEntityOwnerId() {

@Override
public String getEventDescription() {
return "Update load balancer health check policy ID= " + id;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The id attribute here represents the resource's serial ID, right? We should always try to expose the UUID instead

return "Update load balancer health check policy ID = " + id;
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion ...java/org/apache/cloudstack/api/command/user/loadbalancer/UpdateLBStickinessPolicyCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public long getEntityOwnerId() {

@Override
public String getEventDescription() {
return "Update load balancer stickiness policy ID= " + id;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #11649 (comment)

return "Update load balancer stickiness policy ID = " + id;
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/cloudstack/api/command/user/vpn/UpdateVpnConnectionCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public long getEntityOwnerId() {

@Override
public String getEventDescription() {
return "Updating site-to-site VPN connection id= " + id;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #11649 (comment)

return "Updating site-to-site VPN connection ID = " + id;
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/cloudstack/api/command/user/vpn/UpdateVpnGatewayCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public long getEntityOwnerId() {

@Override
public String getEventDescription() {
return "Update site-to-site VPN gateway id= " + id;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #11649 (comment)

return "Update site-to-site VPN gateway ID = " + id;
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion engine/schema/src/main/java/com/cloud/vm/dao/UserVmDaoImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,7 @@ public List<Ternary<Integer, Integer, Integer>> countVmsBySize(long dcId, int li
result.add(new Ternary<Integer, Integer, Integer>(rs.getInt(1), rs.getInt(2), rs.getInt(3)));
}
} catch (Exception e) {
logger.warn("Error counting vms by size for dcId= " + dcId, e);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #11649 (comment)

logger.warn("Error counting vms by size for Data Center ID = " + dcId, e);
}
return result;
}
Expand Down
2 changes: 1 addition & 1 deletion engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,7 @@ public Long countByZoneAndStateAndHostTag(long dcId, State state, String hostTag
return rs.getLong(1);
}
} catch (Exception e) {
logger.warn(String.format("Error counting vms by host tag for dcId= %s, hostTag= %s", dcId, hostTag), e);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #11649 (comment)

logger.warn(String.format("Error counting vms by host tag for dcId = %s, hostTag = %s", dcId, hostTag), e);
}
return 0L;
}
Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2105,7 +2105,7 @@ private Pair<List<ProjectJoinVO>, Integer> listProjectsInternal(ListProjectsCmd
}

if (domainId != null && !domainId.equals(caller.getDomainId())) {
throw new PermissionDeniedException("Can't list domain id= " + domainId + " projects; unauthorized");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #11649 (comment)

throw new PermissionDeniedException("Can't list domain ID = " + domainId + " projects; unauthorized");
}

if (StringUtils.isNotEmpty(username) && !username.equals(user.getUsername())) {
Expand Down
Loading