-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix importing unmanaged instances due to incorrect internal name #11753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix importing unmanaged instances due to incorrect internal name #11753
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11753 +/- ##
============================================
- Coverage 16.17% 16.17% -0.01%
+ Complexity 13296 13294 -2
============================================
Files 5656 5656
Lines 498223 498223
Branches 60454 60454
============================================
- Hits 80577 80576 -1
+ Misses 408676 408675 -1
- Partials 8970 8972 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@blueorangutan package |
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
make sense
@sudo87 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15220 |
@blueorangutan test |
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
@blueorangutan test |
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
tested vm unmanage/import several times, all worked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested
LGTM
[SF] Trillian test result (tid-14475)
|
merging based on approvals and manual test |
[SF] Trillian test result (tid-14476)
|
Description
This PR fixes the import of unmanaged instances, the error was a regression from PR #11659
Fixes: #11737
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested on KVM environment - importing unmanaged instances worked properly
How did you try to break this feature and the system with this change?