-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ui: introduce section-level “advisories” with quick-fix actions #11763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This change adds a lightweight “advisories” mechanism to section configs and ships the first advisory to help operators satisfy some of the CKS prerequisites. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11763 +/- ##
============================================
- Coverage 17.50% 17.50% -0.01%
+ Complexity 15427 15426 -1
============================================
Files 5894 5896 +2
Lines 526845 527030 +185
Branches 64334 64356 +22
============================================
+ Hits 92232 92245 +13
- Misses 424236 424408 +172
Partials 10377 10377
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a lightweight "advisories" mechanism to section configurations that displays warnings and quick-fix actions to help operators satisfy CKS (CloudStack Kubernetes Service) prerequisites. The feature adds advisory alerts with actionable buttons to guide users through common configuration issues.
- Adds advisory system with condition evaluation and quick-fix actions
- Implements three CKS-specific advisories for compute offerings, Kubernetes versions, and endpoint URL configuration
- Provides dismissible alerts with primary/secondary action buttons
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
ui/src/views/AutogenView.vue | Integrates AdvisoriesView component into the main view |
ui/src/config/section/compute.js | Adds three CKS advisories with conditions and fix actions |
ui/src/config/router.js | Extends router metadata to include advisories configuration |
ui/src/components/view/AdvisoriesView.vue | Core advisory component with alert rendering and action handling |
ui/src/api/index.js | Adds getBaseUrl utility function |
ui/public/locales/en.json | Adds localization strings for advisory messages and actions |
Comments suppressed due to low confidence (1)
ui/src/components/view/AdvisoriesView.vue:1
- Use 'const' instead of 'var' for variable declaration to follow modern JavaScript best practices and maintain consistency with the rest of the codebase.
// Licensed to the Apache Software Foundation (ASF) under one
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
cool idea! |
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
Description
This change adds a lightweight “advisories” mechanism to section configs and ships the first advisory to help operators satisfy some of the CKS prerequisites.
The functionality can be disabled by adding
advisoriesDisabled
astrue
in config.json.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
ui-feature-advisory.mp4
How Has This Been Tested?
How did you try to break this feature and the system with this change?