framework-cluster: use bind.interface for cluster communication

[shwstppr]

Description

Fixes #11460

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

bind.interface is a bit misleading, maybe bind.address ?

[shwstppr]

@weizhouapache I'm not sure why it is named that way
https://github.com/apache/cloudstack/blob/main/client/conf/server.properties.in#L20
https://github.com/apache/cloudstack/blob/main/client/src/main/java/org/apache/cloudstack/ServerDaemon.java#L252

I didn't want to change the property name as it already exist

[weizhouapache]

ok, I see
let's keep the name

can you update the description in server.properties ?

[weizhouapache]

I checked the javadoc

https://javadoc.jetty.org/jetty-12/org/eclipse/jetty/server/AbstractNetworkConnector.html#setHost(java.lang.String)

so IP/hostname/null/0.0.0.0 are valid values. maybe we need to consider them ?

[shwstppr]

IP/null/hostname should have been okay. I've added check for wildcards

[codecov]

Codecov Report

❌ Patch coverage is 37.77778% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.54%. Comparing base (5a8a1e2) to head (cc858f3).
⚠️ Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
.../apache/cloudstack/utils/ServerPropertiesUtil.java	7.14%	26 Missing ⚠️
...a/com/cloud/cluster/ClusterServiceServletImpl.java	88.23%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11797      +/-   ##
============================================
+ Coverage     17.50%   17.54%   +0.03%     
- Complexity    15427    15467      +40     
============================================
  Files          5894     5898       +4     
  Lines        526890   527442     +552     
  Branches      64338    64414      +76     
============================================
+ Hits          92240    92522     +282     
- Misses       424272   424524     +252     
- Partials      10378    10396      +18     

Flag	Coverage Δ
uitests	3.60% <ø> (-0.01%)	⬇️
unittests	18.60% <37.77%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.