[CLOUDSTACK-9840] Fix datetime format of snapshots events #2008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the timezone in datetime format of snapshot events, to be consistent with every other events. "eventDateTime" was added by @chipchilders in commit 14ee684 and was updated the same day to add the timezone (commit bf967eb) except for Snapshots.
|
Thanks for this PR @olivierlemasle, could you please add a jira id for this change and rename the PR to [JIRA-ID]: Fix datetime ... same as the others |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-593 |
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
olivierlemasle
changed the title
|
@borisstoyanov Thanks, I've renamed the pull request. Do you want me to rename to commit as well? Additionally, the travis checks hit a timeout; I've closed and opened again this pull request twice to trigger a new build, with no success. |
|
thanks @olivierlemasle that look ok, marvin tests seem to fail, will rerun then now. |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-961)
|
borisstoyanov
approved these changes
Mar 20, 2017
|
The Travis tests have finally succeeded. |
|
@olivierlemasle I think this PR needs at least 2 LGTMs and as agreed Rajani is taking care of mergin PRs. |
kiwiflyer
approved these changes
May 3, 2017
ACS CI BVT RunSumarry: Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 Failed tests:
Skipped tests: Passed test suits: |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the timezone in datetime format of snapshot events, to be consistent with every other events.
"eventDateTime" was added by @chipchilders in commit 14ee684 and was updated the same day to add the timezone (commit bf967eb) except for Snapshots.