Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC Inline LB - CLOUDSTACK-9282 #2010

Open
wants to merge 1 commit into
base: master
from

Conversation

@urvis
Copy link

urvis commented Mar 17, 2017

@prashanthvarma

This comment has been minimized.

Copy link
Contributor

prashanthvarma commented Mar 20, 2017

Validation:

Added Marvin test code PEP8 and PyFlakes compliance:

CloudStack$
CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pyflakes test/integration/component/test_vpcinlinelbvm.py
CloudStack$
CloudStack$ pep8 test/integration/component/test_vpcinlinelbvm.py
CloudStack$

Added Marvin test results:

=> Native ACS Environment:

nosetests --with-marvin --marvin-config=nuage.cfg test/integration/component/test_vpcinlinelbvm.py

Test VpcInlineLbVm basic functionality ... === TestName: test_01_vpcinlinelbvm | Status : SUCCESS ===
ok
Test VpcInlineLbVm basic functionality with traffic ... === TestName: test_02_vpcinlinelbvm_with_traffic | Status : SUCCESS ===
ok
Test VpcInlineLbVm functionality with multiple public IP addresses ... === TestName: test_03_vpcinlinelbvm_with_multiple_public_ips_traffic | Status : SUCCESS ===
ok
Test VpcInlineLbVm functionality with lb rule events by performing ... === TestName: test_04_vpcinlinelbvm_with_lb_rule_events_traffic | Status : SUCCESS ===
ok
Test VpcInlineLbVm functionality with different LB algorithms by ... === TestName: test_05_vpcinlinelbvm_with_algorithms_traffic | Status : SUCCESS ===
ok
Test VpcInlineLbVm functionality with VpcInlineLbVm appliance ... === TestName: test_06_vpcinlinelbvm_appliance_operations_traffic | Status : EXCEPTION ===
ERROR
Test VpcInlineLbVm provider with network restarts and reboots by ... === TestName: test_07_vpcinlinelbvm_with_network_restarts_and_reboots | Status : EXCEPTION ===
ERROR
...
Ran 7 tests in 9684.676s

FAILED (errors=2)

failed_plus_exceptions.txt
results.txt
runinfo.txt

=> ACS + Nuage VSP Environment:

nosetests --with-marvin --marvin-config=nuage.cfg test/integration/plugins/nuagevsp/test_nuage_vpc_vpcinlinelb.py

Test Nuage VSP VpcInlineLbVm basic functionality ... === TestName: test_01_nuage_vpcinlinelbvm | Status : SUCCESS ===
ok
Test Nuage VSP VpcInlineLbVm basic functionality with traffic ... === TestName: test_02_nuage_vpcinlinelbvm_with_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VpcInlineLbVm functionality with multiple public IP ... === TestName: test_03_nuage_vpcinlinelbvm_with_multiple_public_ips_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VpcInlineLbVm functionality with lb rule events by ... === TestName: test_04_nuage_vpcinlinelbvm_with_lb_rule_events_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VpcInlineLbVm functionality with different LB ... === TestName: test_05_nuage_vpcinlinelbvm_with_algorithms_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VpcInlineLbVm functionality with VpcInlineLbVm ... === TestName: test_06_nuage_vpcinlinelbvm_appliance_operations_traffic | Status : EXCEPTION ===
ERROR
Test Nuage VSP VpcInlineLbVm functionality with network reboots and ... === TestName: test_07_nuage_vpcinlinelbvm_with_network_restarts_and_reboots | Status : FAILED ===
FAIL

Ran 7 tests in 12476.607s

FAILED (errors=1, failures=1)

failed_plus_exceptions.txt
results.txt
runinfo.txt

=> Concurrency tests

Thread Count: 15

nosetests --with-marvin --marvin-config=nuage.cfg test/integration/plugins/nuagevsp/test_nuage_vpc_vpcinlinelb.py

Test Nuage VSP VPC Network Public Load Balancing Rules Concurrency ... === TestName: test_01_nuage_vpc_network_public_lb_rules_concurrency | Status : SUCCESS ===
ok


Ran 1 test in 1606.907s

OK

results.txt
runinfo.txt

Note: The above test failures are due to the bug: https://issues.apache.org/jira/browse/CLOUDSTACK-9837

@prashanthvarma prashanthvarma force-pushed the nuagenetworks:feature/vpc_inline_lb branch 3 times, most recently from b88ec4b to e347d82 Mar 21, 2017
@prashanthvarma prashanthvarma force-pushed the nuagenetworks:feature/vpc_inline_lb branch from e347d82 to 6bf3f68 Apr 7, 2017
@prashanthvarma prashanthvarma force-pushed the nuagenetworks:feature/vpc_inline_lb branch 2 times, most recently from 8b66232 to 3a5664b Apr 18, 2017
@fmaximus fmaximus force-pushed the nuagenetworks:feature/vpc_inline_lb branch 2 times, most recently from 0f158b6 to 634b34f Sep 29, 2017
@fmaximus fmaximus force-pushed the nuagenetworks:feature/vpc_inline_lb branch from 634b34f to 992dc37 Oct 12, 2017
Copy link
Contributor

smeetsr left a comment

I reran same tests, with same results as before, so approving this PR.

Test Nuage VSP VpcInlineLbVm basic functionality ... === TestName: test_01_nuage_vpcinlinelbvm | Status : SUCCESS ===
ok
Test Nuage VSP VpcInlineLbVm basic functionality with traffic ... === TestName: test_02_nuage_vpcinlinelbvm_with_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VpcInlineLbVm functionality with multiple public IP ... === TestName: test_03_nuage_vpcinlinelbvm_with_multiple_public_ips_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VpcInlineLbVm functionality with lb rule events by ... === TestName: test_04_nuage_vpcinlinelbvm_with_lb_rule_events_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VpcInlineLbVm functionality with different LB ... === TestName: test_05_nuage_vpcinlinelbvm_with_algorithms_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VpcInlineLbVm functionality with VpcInlineLbVm ... === TestName: test_06_nuage_vpcinlinelbvm_appliance_operations_traffic | Status : EXCEPTION ===
ERROR
Test Nuage VSP VpcInlineLbVm functionality with network reboots and ... === TestName: test_07_nuage_vpcinlinelbvm_with_network_restarts_and_reboots | Status : SUCCESS ===
ok

Test Nuage VSP VPC Network Public Load Balancing Rules Concurrency ... === TestName: test_01_nuage_vpc_network_public_lb_rules_concurrency | Status : SUCCESS ===
ok


Ran 1 test in 1431.866s

OK

@fmaximus fmaximus force-pushed the nuagenetworks:feature/vpc_inline_lb branch 2 times, most recently from 8fc60b4 to 233ebcd Nov 2, 2017
Co-Authored-By: Frank Maximus <frank.maximus@nuagenetworks.net>
Co-Authored-By: Prashanth Manthena <prashanth.manthena@nuagenetworks.net>

Bug: https://issues.apache.org/jira/browse/CLOUDSTACK-9282

Design-Doc: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61340894
@fmaximus fmaximus force-pushed the nuagenetworks:feature/vpc_inline_lb branch from 233ebcd to 1feb599 Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.