list VMs by displayname instead of name #8503

DaanHoogland · 2024-01-12T15:08:44Z

Description

This PR addresses #4654 (comment) TBD

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

in qa

codecov · 2024-01-12T15:16:59Z

Codecov Report

Attention: Patch coverage is 50.14767% with 844 lines in your changes are missing coverage. Please review.

Project coverage is 30.73%. Comparing base (76aff0f) to head (8cb9dcf).
Report is 25 commits behind head on 4.18.

❗ Current head 8cb9dcf differs from pull request most recent head 36be215. Consider uploading reports for the commit 36be215 to get more accurate results

Files	Patch %	Lines
api/src/main/java/com/cloud/gpu/GPU.java	0.00%	98 Missing ⚠️
...apache/cloudstack/api/response/BucketResponse.java	0.00%	69 Missing ⚠️
...stack/api/command/user/bucket/CreateBucketCmd.java	2.56%	38 Missing ⚠️
...i/response/SecondaryStorageHeuristicsResponse.java	0.00%	34 Missing ⚠️
...nt/resource/consoleproxy/ConsoleProxyResource.java	0.00%	33 Missing ⚠️
...e/cloudstack/api/command/admin/vm/ImportVmCmd.java	3.12%	31 Missing ⚠️
...stack/api/command/user/bucket/UpdateBucketCmd.java	3.84%	25 Missing ⚠️
...ack/api/command/user/snapshot/CopySnapshotCmd.java	51.06%	15 Missing and 8 partials ⚠️
...command/admin/storage/AddObjectStoragePoolCmd.java	40.54%	20 Missing and 2 partials ⚠️
...e/cloudstack/api/response/ObjectStoreResponse.java	9.52%	19 Missing ⚠️
... and 92 more

Additional details and impacted files

@@              Coverage Diff              @@
##               4.18    #8503       +/-   ##
=============================================
+ Coverage     13.12%   30.73%   +17.60%     
- Complexity     9142    33911    +24769     
=============================================
  Files          2720     5341     +2621     
  Lines        257744   374971   +117227     
  Branches      40182    54546    +14364     
=============================================
+ Hits          33839   115242    +81403     
- Misses       219615   244488    +24873     
- Partials       4290    15241    +10951

Flag	Coverage Δ
simulator-marvin-tests	`24.61% <28.05%> (?)`
uitests	`4.39% <ø> (?)`
unit-tests	`16.48% <34.61%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

weizhouapache · 2024-01-12T15:17:32Z

@DaanHoogland
both ?

DaanHoogland · 2024-01-12T16:05:21Z

Or not, to be discussed

DaanHoogland · 2024-01-12T19:14:16Z

@blueorangutan ui

sureshanaparti · 2024-01-16T04:41:55Z

@blueorangutan ui

blueorangutan · 2024-01-16T10:40:04Z

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

shwstppr · 2024-01-16T11:53:38Z

@blueorangutan ui

blueorangutan · 2024-01-16T11:54:04Z

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-01-16T12:09:17Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8503 (QA-JID-263)

vishesh92

clgtm

DaanHoogland · 2024-01-18T09:20:04Z

@blueorangutan ui

blueorangutan · 2024-01-18T09:21:04Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-01-18T09:32:57Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8503 (QA-JID-265)

rohityadavcloud · 2024-01-19T04:31:39Z

As far as I know that weren't regressions; As part of #7833 since the display and name are the same for most users, having two redundant columns - so one of the two were removed as part of polish idea on #7833: Standardise most resources to show state/status columns right after resource name (wherever applicable) and Remove displayname column in VM list view, add cpu number and memory by default.
@DaanHoogland cc @andrijapanicsb

rohityadavcloud

I actually prefer name to display name; but I've no objection if everybody agrees with the changes. Historical context: for many resources we've a name and a displayname, which is because CPBM and other portal/layers could refer to a resource by its display name while internally in ACS it could be referred to as name.

DaanHoogland · 2024-02-06T08:53:38Z

@andrijapanicsb can you give your uncensored input on this?

DaanHoogland · 2024-04-26T10:54:59Z

ping @andrijapanicsb

andrijapanicsb · 2024-04-26T11:22:03Z

I did RTFM the whole thing, and the original issue/comments.

LGTM - I think redundancy makes no sense (having both fields), especially since VMs created by UI have identical values for both.

codecov-commenter · 2024-04-26T12:27:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.24%. Comparing base (9d5d4e5) to head (7faa31c).

Additional details and impacted files

@@             Coverage Diff              @@
##               4.18    #8503      +/-   ##
============================================
- Coverage     12.24%   12.24%   -0.01%     
+ Complexity     9291     9290       -1     
============================================
  Files          4698     4698              
  Lines        414259   414259              
  Branches      51377    51765     +388     
============================================
- Hits          50707    50706       -1     
- Misses       357251   357252       +1     
  Partials       6301     6301

Flag	Coverage Δ
unittests	`12.24% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DaanHoogland · 2024-04-26T12:39:59Z

@blueorangutan ui

blueorangutan · 2024-04-26T12:41:04Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-04-26T12:52:53Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8503 (QA-JID-325)

kiranchavala · 2024-06-12T10:32:57Z

@blueorangutan ui

blueorangutan · 2024-06-12T10:34:03Z

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-06-12T10:47:16Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8503 (QA-JID-372)

kiranchavala

LGTM, name is changed to displayname

Before

After

boring-cyborg bot added the component:UI label Jan 12, 2024

DaanHoogland requested review from rohityadavcloud and shwstppr January 12, 2024 15:08

DaanHoogland force-pushed the nameDisplayInList branch from 36be215 to 8cb9dcf Compare January 12, 2024 19:13

vishesh92 approved these changes Jan 17, 2024

View reviewed changes

DaanHoogland force-pushed the nameDisplayInList branch from 8cb9dcf to 36be215 Compare January 18, 2024 09:19

DaanHoogland changed the base branch from main to 4.18 January 18, 2024 09:19

DaanHoogland added this to the 4.18.2.0 milestone Jan 18, 2024

DaanHoogland marked this pull request as ready for review January 18, 2024 09:43

rohityadavcloud reviewed Feb 5, 2024

View reviewed changes

DaanHoogland added the Severity:Minor label Feb 28, 2024

JoaoJandre modified the milestones: 4.18.2.0, 4.18.3 Mar 21, 2024

andrijapanicsb self-requested a review April 26, 2024 11:22

andrijapanicsb approved these changes Apr 26, 2024

View reviewed changes

DaanHoogland added the status:needs-testing label Apr 26, 2024

list by displayname instead of name

7faa31c

DaanHoogland force-pushed the nameDisplayInList branch from 36be215 to 7faa31c Compare April 26, 2024 12:39

kiranchavala self-assigned this Jun 12, 2024

kiranchavala approved these changes Jun 12, 2024

View reviewed changes

kiranchavala removed the status:needs-testing label Jun 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

list VMs by displayname instead of name #8503

list VMs by displayname instead of name #8503

DaanHoogland commented Jan 12, 2024 •

edited

codecov bot commented Jan 12, 2024 •

edited

weizhouapache commented Jan 12, 2024

DaanHoogland commented Jan 12, 2024

DaanHoogland commented Jan 12, 2024

sureshanaparti commented Jan 16, 2024

blueorangutan commented Jan 16, 2024

shwstppr commented Jan 16, 2024

blueorangutan commented Jan 16, 2024

blueorangutan commented Jan 16, 2024

vishesh92 left a comment

DaanHoogland commented Jan 18, 2024

blueorangutan commented Jan 18, 2024

blueorangutan commented Jan 18, 2024

rohityadavcloud commented Jan 19, 2024 •

edited

rohityadavcloud left a comment •

edited

DaanHoogland commented Feb 6, 2024

DaanHoogland commented Apr 26, 2024

andrijapanicsb commented Apr 26, 2024

codecov-commenter commented Apr 26, 2024 •

edited

DaanHoogland commented Apr 26, 2024

blueorangutan commented Apr 26, 2024

blueorangutan commented Apr 26, 2024

kiranchavala commented Jun 12, 2024

blueorangutan commented Jun 12, 2024

blueorangutan commented Jun 12, 2024

kiranchavala left a comment

list VMs by displayname instead of name #8503

Are you sure you want to change the base?

list VMs by displayname instead of name #8503

Conversation

DaanHoogland commented Jan 12, 2024 • edited

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov bot commented Jan 12, 2024 • edited

Codecov Report

weizhouapache commented Jan 12, 2024

DaanHoogland commented Jan 12, 2024

DaanHoogland commented Jan 12, 2024

sureshanaparti commented Jan 16, 2024

blueorangutan commented Jan 16, 2024

shwstppr commented Jan 16, 2024

blueorangutan commented Jan 16, 2024

blueorangutan commented Jan 16, 2024

vishesh92 left a comment

Choose a reason for hiding this comment

DaanHoogland commented Jan 18, 2024

blueorangutan commented Jan 18, 2024

blueorangutan commented Jan 18, 2024

rohityadavcloud commented Jan 19, 2024 • edited

rohityadavcloud left a comment • edited

Choose a reason for hiding this comment

DaanHoogland commented Feb 6, 2024

DaanHoogland commented Apr 26, 2024

andrijapanicsb commented Apr 26, 2024

codecov-commenter commented Apr 26, 2024 • edited

Codecov Report

DaanHoogland commented Apr 26, 2024

blueorangutan commented Apr 26, 2024

blueorangutan commented Apr 26, 2024

kiranchavala commented Jun 12, 2024

blueorangutan commented Jun 12, 2024

blueorangutan commented Jun 12, 2024

kiranchavala left a comment

Choose a reason for hiding this comment

DaanHoogland commented Jan 12, 2024 •

edited

codecov bot commented Jan 12, 2024 •

edited

rohityadavcloud commented Jan 19, 2024 •

edited

rohityadavcloud left a comment •

edited

codecov-commenter commented Apr 26, 2024 •

edited