Honour listall param for list templates api

[vishesh92]

Description

This PR makes changes to honour listall param for list templates api and also adds the listall parameter to deployVM in the UI.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.28%. Comparing base (620ed16) to head (b9a6ec7).
Report is 5 commits behind head on 4.19.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #9300       +/-   ##
============================================
- Coverage     14.95%   4.28%   -10.68%     
============================================
  Files          5387     364     -5023     
  Lines        470348   29439   -440909     
  Branches      58589    5146    -53443     
============================================
- Hits          70330    1260    -69070     
+ Misses       392224   28036   -364188     
+ Partials       7794     143     -7651     

Flag	Coverage Δ
uitests	4.28% <ø> (-0.01%)	⬇️
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sureshanaparti]

clgtm

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10110

[slavkap]

I'm not sure how to properly test this, but here are the results from a few scenarios:
1 - I've created a project and downloaded a template. When I open the deploy VM wizard I can see it.
2 - I've created another project, and when I open the wizard I see the template of the first project
3 - when I open the default view and try to deploy a VM I see only the template from the first project, but I have a few more when I list them from the Image tab
4 - I've deleted the projects and have only the default view, and there aren't any templates listed when using the Deploy VM wizard

[vishesh92]

I'm not sure how to properly test this, but here are the results from a few scenarios: 1 - I've created a project and downloaded a template. When I open the deploy VM wizard I can see it. 2 - I've created another project, and when I open the wizard I see the template of the first project 3 - when I open the default view and try to deploy a VM I see only the template from the first project, but I have a few more when I list them from the Image tab 4 - I've deleted the projects and have only the default view, and there aren't any templates listed when using the Deploy VM wizard

Thanks @slavkap . This is probably a UI issue. Let me check & fix this.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10125

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10134

[slavkap]

Code LGTM, I tested the scenarios that I mentioned above.
I'm not sure what should be the behavior for the templates in the community section in the Deploy VM wizard. If I have a project and download a template, then create another project, the second project has access to the template of the first one via the community tab

[sureshanaparti]

Verified listing of templates in default view and projects.