Fix to allow actions on the network if it belongs to a project

[harikrishna-patnala]

Description

This PR fixes the issue #9413

The original fix was to allow user to do actions (update, restart, delete) on the network only if the user owns the network and if user role is of Admin or domain admin.

If the network belongs to a project then the actions can be allowed as it belongs to only to that project.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

Before fix with a network in project

After fix with a network in project

How Has This Been Tested?

1. Create an account of type user
2. Login with that user
3. Create a project and switch to that project
4. Create a new network in that project
5. Before fix user won't be able to do any actions on that network, after fix it is allowed.

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.54%. Comparing base (2ba64f2) to head (6b51570).
Report is 11 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##               main    #9550    +/-   ##
==========================================
  Coverage     15.54%   15.54%            
- Complexity    11995    11997     +2     
==========================================
  Files          5499     5499            
  Lines        481706   481706            
  Branches      58660    58852   +192     
==========================================
+ Hits          74879    74884     +5     
+ Misses       398541   398535     -6     
- Partials       8286     8287     +1     

Flag	Coverage Δ
uitests	4.17% <ø> (ø)
unittests	16.32% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10703

[DaanHoogland]

clgtm, but wonder if this covours all basis (viewers of a project that have a view only role in the project for instance)

[vladimirpetrov]

LGTM based on manual testing using the steps provided in the PR description. Tested before and after the patch.