Fix user agent match issue android pie

[pradiv-kumar]

Platforms affected

Android

What does this PR do?

Fix the user agent match issue in Android Pie devices #534

What testing has been done on this change?

Checklist

• [Reported an issue] User agent check in Cordova.js raises exception in Android 9 #534
• Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
• Added automated test coverage as appropriate for this change.

[codecov-io]

Codecov Report

Merging #535 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   61.87%   61.87%           
=======================================
  Files          17       17           
  Lines        1975     1975           
  Branches      366      366           
=======================================
  Hits         1222     1222           
  Misses        753      753

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e58453d...cf2dd6f. Read the comment docs.

[brody4hire]

Thanks for the contribution. Considering that check is only used to check for version range of 4.0...4.3 and minimum Android version is now 4.4 ([1]) I would suggest a much simpler solution: simply remove the lines that check check and version_code, along with some of the comments above.

Another note is that we generally use the cordova-coho tool to generate bin/templates/project/assets/www/cordova.js. I would prefer if that you remove the change to bin/templates/project/assets/www/cordova.js from this PR.

[1] https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#requirements-and-support