eslint cleanup fixes: operator-linebreak #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reformat ternary expresssions according to (semi)standard
- reformat error message expressions according to (semi)standard
as done by the following command with no operator-linebreak exception
enabled:
npm run eslint -- --fix
brodycj
requested review from
janpio,
dpogue,
raphinesse,
erisu,
jcesarmobile and
knight9999
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 89.04% 89.04%
=======================================
Files 20 20
Lines 1826 1826
Branches 374 374
=======================================
Hits 1626 1626
Misses 200 200
Continue to review full report at Codecov.
|
raphinesse
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operator-linebreakexception from.eslintrc.ymlas done by the following command, with no
operator-linebreakexception enabled:I am breaking this proposal out of PR #82 due to its seemingly controversial nature.
I would really favor applying these fixes, which I think are consistent with both (semi)standard and Prettier styling.