CB-10516: Remove h3-h6 from showing up in docs ToC #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing h3-h6 from showing up in docs ToC
|
LGTM |
|
I'm still a bit unconvinced that all H3 - H6 headings should be excluded from ToC across the board. This is specific to the reference pages, isn't it? |
|
No, I don't think it is. What special meaning does H3+ have in the TOC? All of our TOC entries for a page are presented without hierarchy in the sidebar; H3+ lose all meaning in that format and become semantically the same in importance as H2 in the TOC, which does not make sense. |
|
Hmm, that's a good point. I guess if we ever do implement levels in the page ToC then we can always just put them back. LGTM then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing h3-h6 from showing up in docs ToC
@dblotsky @riknoll @nikhilkh Can you please review and merge this PR?