Skip to content

Conversation

omefire
Copy link
Contributor

@omefire omefire commented Mar 3, 2016

No description provided.

@omefire
Copy link
Contributor Author

omefire commented Mar 3, 2016

@rakatyal , could you please help review this ?

@@ -189,7 +189,7 @@ platform. See [Customize icons topic](images.html) for more information.
<allow-intent href="sms:*" />

## engine
Specifies what platform to restore during a prepare. For more details, see the [Platforms & Plugins Version Management](../platform_plugin_versioning_ref/index.html).
Specifies what platform to restore during a prepare. For more details, see the [Platforms & Plugins Version Management](../platform_plugin_versioning_ref/index.html#platform-versioning).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the link to the updated title: "Manage versions and platforms"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TOC tile should really be renamed "Manage platforms and plugins"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Manage platforms and plugins" doesn't really convey the intent behind the info included in that link. It brings to my mind actions like: add/rm/update platforms/plugins.

I think the original "Platforms & Plugins Versioning" was much clearer, versioning being the keyword here.

@asfgit asfgit merged commit 47955eb into apache:master Mar 10, 2016
@riknoll
Copy link
Contributor

riknoll commented Mar 10, 2016

I know this was merged, but there was another part to the JIRA. The example config.xml at the bottom of the file uses the plugin tag incorrectly (version should be spec)

@omefire
Copy link
Contributor Author

omefire commented Mar 10, 2016

@riknoll 👍
handled.

@riknoll
Copy link
Contributor

riknoll commented Mar 10, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants