Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-523 : ignore swift version settings of cocoapods libraries on windows #528

Conversation

knight9999
Copy link
Contributor

@knight9999 knight9999 commented Feb 14, 2019

Platforms affected

cordova-ios

Motivation and Context

Fixing the issue #523

Description

To avoid error on windows, adding checks cocoapods is available or not before changing swift version of cocoapods libraries.

Testing

In my local Mac,
create project and adding phonegap-plugin-push.
Checking build.
Checking the application can receive push notifications.
(by using cordova@nightly)

In my local Windows 10,
create project and adding phonegap-plugin-push.
Checking to skip the cocoapods specific process.
(by using cordova@8.1.0)

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with ios if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

…nvironment by using check_reqs.check_cocoapods function
@codecov-io
Copy link

codecov-io commented Feb 14, 2019

Codecov Report

Merging #528 into master will decrease coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
- Coverage   74.75%   74.63%   -0.13%     
==========================================
  Files          11       11              
  Lines        1822     1825       +3     
==========================================
  Hits         1362     1362              
- Misses        460      463       +3
Impacted Files Coverage Δ
bin/templates/scripts/cordova/Api.js 70.46% <0%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c1f60...b9696b1. Read the comment docs.

@janpio
Copy link
Member

janpio commented Feb 14, 2019

Awesome, super quick response @knight9999!

Just for my understanding: When is pod install and the code that you guarded in this PR run for the project then? First time being used on macOS?

@knight9999
Copy link
Contributor Author

@janpio I simply added check_reqs.check_cocoapods() to cocoapod related function as same as the case of pod install in cordova 4.5.*.

check_reqs.check_cocoapods checks os type, cocoapods is installed or not, and cocoapods version is suitable or not. It shows appropriate warning message if necessary.

@janpio
Copy link
Member

janpio commented Feb 15, 2019

Ok, so when I add some plugin on Windows and commit, then check out on a Mac and keep working there it will still run pod install and do all the things sooner or later? No way to break the project?

@janpio janpio added the bug label Mar 1, 2019
@dpogue dpogue added this to the 5.0.1 milestone Mar 2, 2019
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dpogue dpogue merged commit ae4d1fd into apache:master Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants