Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scoped plugins #821

Merged
merged 8 commits into from
Nov 15, 2019
Merged

Support scoped plugins #821

merged 8 commits into from
Nov 15, 2019

Conversation

raphinesse
Copy link
Contributor

Motivation and Context

See #602 for details. Closes #680.

Description

This contains the revised changes from #680 minus the changes from #818 and apache/cordova-common#94.

Testing

Only unit testing so far

@codecov-io
Copy link

Codecov Report

Merging #821 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #821      +/-   ##
==========================================
+ Coverage   89.27%   89.28%   +0.01%     
==========================================
  Files          47       47              
  Lines        2172     2156      -16     
==========================================
- Hits         1939     1925      -14     
+ Misses        233      231       -2
Impacted Files Coverage Δ
src/cordova/plugin/plugin_spec_parser.js 100% <100%> (ø) ⬆️
src/plugman/uninstall.js 93.46% <100%> (ø) ⬆️
src/cordova/plugin/add.js 99.09% <100%> (+0.43%) ⬆️
src/plugman/install.js 90.87% <100%> (-0.08%) ⬇️
src/cordova/util.js 93.61% <100%> (+0.37%) ⬆️
src/plugman/util/metadata.js 100% <100%> (ø) ⬆️
src/cordova/platform/addHelper.js 94.73% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be96be9...ea5266d. Read the comment docs.

package.json Show resolved Hide resolved
@raphinesse raphinesse merged commit ff66281 into apache:master Nov 15, 2019
@raphinesse raphinesse deleted the scoped-plugins branch November 15, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants